Merged
Conversation
ecbad3c to
c574241
Compare
0fdfe9d to
3f5aabe
Compare
This commit adds support for UDP statsd sinks with the STATSD_PROTOCOL environment variable and the WithStatsdProtocol() SinkOption.
3f5aabe to
20c1594
Compare
twoism
previously approved these changes
Apr 15, 2020
| // buffer size that will prevent datagram fragmentation. | ||
| var bufSize int | ||
| switch s.conf.StatsdProtocol { | ||
| case "udp", "udp4", "udp6": |
Contributor
Author
There was a problem hiding this comment.
I normally would, but I think having something like:
const (
ProtocolUDP = "udp"
ProtocolUDP4 = "udp4"
ProtocolUDP6 = "udp6"
ProtocolTCP = "tcp"
ProtocolTCP4 = "tcp4"
ProtocolTCP6 = "tcp6"
)Would add more noise than it's worth and wouldn't be as clear.
Contributor
Author
|
Note: fixing an issue with timing (the test explicitly tests timing so can't/won't mock) on Travis since it is very slow. |
added 3 commits
April 16, 2020 15:32
This test is incredibly fast so doesn't need to run in parallel and I'm trying to reduce the number of goroutines we have in flight at any time during out tests.
Due to the nature of UDP the reconnect test is flaky (especially when ran with the race detector) this "fixes" it by changing it to log failures instead of failing the test.
twoism
approved these changes
Apr 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds support for UDP statsd sinks with the STATSD_PROTOCOL
environment variable and the WithStatsdProtocol() SinkOption.
Extends the work initially started with: #47