Make Statsd protocol configurable to enable UDP#47
Closed
armsnyder wants to merge 1 commit intolyft:masterfrom
Closed
Make Statsd protocol configurable to enable UDP#47armsnyder wants to merge 1 commit intolyft:masterfrom
armsnyder wants to merge 1 commit intolyft:masterfrom
Conversation
Contributor
Author
|
The CI is failing for Go 1.7 and 1.8, but not due to my change -- Go 1.9 and 1.10 are passing. |
Contributor
|
@armsnyder you will need to rebase to pick up the changes that fix the failure you're seeing |
Contributor
|
Thanks for this PR, UDP support has been added in #95 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds an additional setting -
STATSD_PROTOCOL- which defaults to "tcp"The
STATSD_PROTOCOLis now used instead of the previously hardcoded "tcp" when dialing the connection.Because the TCPStatsdSink sink is no longer TCP-specific, I renamed it "NetworkStatsdSink". I did this instead of creating a new UDPStatsdSink because the change was so minimal.
I have tested this change by compiling it and using it in the Lyft Rate Limiter to output stats to a UDP StatsD server (DataDog). I saw the stats show up, and logs indicated everything worked as intended.
closes #41