Remove deprecated legacy cookie format support#2215
Merged
Conversation
24db5bf to
e7a0760
Compare
Drop the legacy-format fallback in CookieJar::load that relied on the deprecated ReqwestCookieStore::load_json. The cookie_store::serde::json format has been the default for nearly two years. Empty cookie jar files (e.g. created via touch) are still loaded gracefully as an empty store, matching the previous behavior, and unit tests cover the missing-file, empty-file, and new-format cases. Closes #2213
e7a0760 to
2c22b04
Compare
Member
Author
|
I noticed that the removed legacy fallback used to silently handle empty files. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2208 (review comment by @thomas-zahner) and closes #2213.
CookieJar::loadpreviously fell back to the legacy cookie store format via the deprecatedReqwestCookieStore::load_json. The newcookie_store::serde::jsonformat has been the default for almost 2 years, so this drops support for the old format and the associated#[allow(deprecated)].