Remove deprecated flags from codebase.#2208
Merged
Merged
Conversation
This affects the following flags: - `--exclude-file`, which got replaced by `.lycheeignore` - `--base`, superceded by `--base-url`.
katrinafyi
approved these changes
May 26, 2026
katrinafyi
left a comment
Member
There was a problem hiding this comment.
I'm happy with this. Indeed, we have made other breaking changes without such a long notice period as these options have had.
thomas-zahner
approved these changes
May 26, 2026
thomas-zahner
left a comment
Member
There was a problem hiding this comment.
I totally agree with this change and see no issues.
Not related to flags, but noticed while searching for deprecations; maybe we could now remove this deprecated usage. It's probably okay to drop support for the old format after almost 2 years. What are your thoughts? Could be done in a separate PR.
lychee/lychee-lib/src/types/cookies.rs
Line 39 in ee86f0d
Member
Author
|
Thanks for review. I will create a follow-up PR for the deprecated code. |
This was referenced May 30, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eventually we have to get rid of the long-deprecated flags in lychee. And I believe now is as good of a time as ever. We don't have to wait for 1.0 to hit (I believe).
This affects the following flags:
--exclude-file, which got replaced by.lycheeignore--base, superceded by--base-url.Wdyt about merging this in and announcing the removal with the next release?
If we decide to do that, I can prepare a PR to update the lychee docs and the lychee action.