fix: update binstall metadata after 0.24.0 restructure#2165
Merged
Conversation
just remove bin-dir because they can be auto-detected and this is more robust against future changes and different operating systems: https://github.com/cargo-bins/cargo-binstall/blob/main/SUPPORT.md#defaults
This reverts commit 3bf07e1.
This reverts commit e375f18.
Member
|
Ouch, yeah, that's on me. Thanks for fixing. |
This was referenced Apr 24, 2026
Merged
mre
added a commit
that referenced
this pull request
Apr 25, 2026
Dropping it caused binstall to resolve the latest published release (0.24.1), whose archive still has the pre-#2165 layout, so the job fails with 'lychee bin not found'. Using the in-tree manifest is the whole point: it validates the metadata before the next release.
thomas-zahner
pushed a commit
that referenced
this pull request
Apr 27, 2026
* ci: fix flaky binstall-check job Two failure modes were causing red CI on unrelated PRs and on every release-plz PR: - Unauthenticated api.github.com requests hit 403 under contention. Pass GITHUB_TOKEN so binstall's GitHub API calls are authenticated. - Release PRs bump the in-tree version to one that is not published yet, so '--manifest-path .' made binstall look for a non-existent release. Drop the flag so binstall resolves the latest published version, and skip the job entirely on release-plz branches. * ci: keep --manifest-path . in binstall-check Dropping it caused binstall to resolve the latest published release (0.24.1), whose archive still has the pre-#2165 layout, so the job fails with 'lychee bin not found'. Using the in-tree manifest is the whole point: it validates the metadata before the next release.
3 tasks
donbeave
added a commit
to jackin-project/jackin
that referenced
this pull request
May 1, 2026
Bumps LYCHEE_VERSION in .github/workflows/docs.yml from v0.24.1 to v0.24.2. Tarball layout is unchanged from v0.24.1 (lycheeverse/lychee#2165 is binstall-metadata only), so the existing post-v2.8.0 master SHA pin on lycheeverse/lychee-action continues to handle extraction correctly. Also trims historical archaeology from the LYCHEE_VERSION comment block; the durable rationale (sitemap support forces us past lychee-action's v0.23.0 default) stays. Per-version detail now lives in TODO.md "Last verified". The lychee-action-sha-pin TODO remains open — lycheeverse/lychee-action has not tagged anything past v2.8.0 yet. TODO.md "Last verified" date refreshed to 2026-05-01. Signed-off-by: Alexey Zhokhov <alexey@zhokhov.com> Co-authored-by: Claude <noreply@anthropic.com>
donbeave
added a commit
to jackin-project/jackin
that referenced
this pull request
May 6, 2026
Bumps LYCHEE_VERSION in .github/workflows/docs.yml from v0.24.1 to v0.24.2. Tarball layout is unchanged from v0.24.1 (lycheeverse/lychee#2165 is binstall-metadata only), so the existing post-v2.8.0 master SHA pin on lycheeverse/lychee-action continues to handle extraction correctly. Also trims historical archaeology from the LYCHEE_VERSION comment block; the durable rationale (sitemap support forces us past lychee-action's v0.23.0 default) stays. Per-version detail now lives in TODO.md "Last verified". The lychee-action-sha-pin TODO remains open — lycheeverse/lychee-action has not tagged anything past v2.8.0 yet. TODO.md "Last verified" date refreshed to 2026-05-01. Signed-off-by: Alexey Zhokhov <alexey@zhokhov.com> Co-authored-by: Claude <noreply@anthropic.com>
donbeave
added a commit
to jackin-project/jackin
that referenced
this pull request
May 7, 2026
Bumps LYCHEE_VERSION in .github/workflows/docs.yml from v0.24.1 to v0.24.2. Tarball layout is unchanged from v0.24.1 (lycheeverse/lychee#2165 is binstall-metadata only), so the existing post-v2.8.0 master SHA pin on lycheeverse/lychee-action continues to handle extraction correctly. Also trims historical archaeology from the LYCHEE_VERSION comment block; the durable rationale (sitemap support forces us past lychee-action's v0.23.0 default) stays. Per-version detail now lives in TODO.md "Last verified". The lychee-action-sha-pin TODO remains open — lycheeverse/lychee-action has not tagged anything past v2.8.0 yet. TODO.md "Last verified" date refreshed to 2026-05-01. Co-authored-by: Claude <noreply@anthropic.com> Signed-off-by: Alexey Zhokhov <alexey@zhokhov.com> Co-authored-by: Codex <codex@openai.com>
donbeave
added a commit
to jackin-project/jackin
that referenced
this pull request
May 7, 2026
Bumps LYCHEE_VERSION in .github/workflows/docs.yml from v0.24.1 to v0.24.2. Tarball layout is unchanged from v0.24.1 (lycheeverse/lychee#2165 is binstall-metadata only), so the existing post-v2.8.0 master SHA pin on lycheeverse/lychee-action continues to handle extraction correctly. Also trims historical archaeology from the LYCHEE_VERSION comment block; the durable rationale (sitemap support forces us past lychee-action's v0.23.0 default) stays. Per-version detail now lives in TODO.md "Last verified". The lychee-action-sha-pin TODO remains open — lycheeverse/lychee-action has not tagged anything past v2.8.0 yet. TODO.md "Last verified" date refreshed to 2026-05-01. Signed-off-by: Renovate Bot <renovate@whitesourcesoftware.com>
donbeave
added a commit
to jackin-project/jackin
that referenced
this pull request
May 7, 2026
Bumps LYCHEE_VERSION in .github/workflows/docs.yml from v0.24.1 to v0.24.2. Tarball layout is unchanged from v0.24.1 (lycheeverse/lychee#2165 is binstall-metadata only), so the existing post-v2.8.0 master SHA pin on lycheeverse/lychee-action continues to handle extraction correctly. Also trims historical archaeology from the LYCHEE_VERSION comment block; the durable rationale (sitemap support forces us past lychee-action's v0.23.0 default) stays. Per-version detail now lives in TODO.md "Last verified". The lychee-action-sha-pin TODO remains open — lycheeverse/lychee-action has not tagged anything past v2.8.0 yet. TODO.md "Last verified" date refreshed to 2026-05-01. Signed-off-by: Renovate Bot <renovate@whitesourcesoftware.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
just remove bin-dir and pkg-fmt because they can be auto-detected and this is more robust against future changes and different operating systems: https://github.com/cargo-bins/cargo-binstall/blob/main/SUPPORT.md#defaults
this is the error without these changes:
related to #2160. the failure of binstall breakas pre-commit (and probably other things)