fix(luajit) add 'metatype' as a patched method#631
Merged
Conversation
Abstracts the patching into its own module as well
Member
Author
|
@ajacksified imo this is good to go. But merging it also requires uploading the new SCM-2 rockspec to LuaRocks. Can you merge and upload? |
Member
Author
|
ping @ajacksified |
Member
Author
|
@ajacksified @DorianGray ping again. I do not mind uploading the rockspecs if you can provide me with a token luarocks.org > login > settings > API keys > generate new key |
unleashed
added a commit
to 3scale/APIcast
that referenced
this pull request
Sep 5, 2021
This has landed in the next Busted release and handles the issue of calling FFI.metadata (and others) twice in the same environment by stubbing the actual call with a table lookup to pick up previous results. See lunarmodules/busted#631 for details.
unleashed
added a commit
to 3scale/APIcast
that referenced
this pull request
Sep 5, 2021
This has landed in the next Busted release and handles the issue of calling FFI.metadata (and others) twice in the same environment by stubbing the actual call with a table lookup to pick up previous results. See lunarmodules/busted#631 for details.
unleashed
added a commit
to 3scale/APIcast
that referenced
this pull request
Sep 5, 2021
This has landed in the next Busted release and handles the issue of calling FFI.metadata (and others) twice in the same environment by stubbing the actual call with a table lookup to pick up previous results. See lunarmodules/busted#631 for details.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Abstracts the patching into its own module as well
fixes #630