Add conditional printing to Flambda_cmx_format#2
Merged
lukemaurer merged 2 commits intolukemaurer:objinfo-no-codefrom Jun 28, 2024
Merged
Add conditional printing to Flambda_cmx_format#2lukemaurer merged 2 commits intolukemaurer:objinfo-no-codefrom
lukemaurer merged 2 commits intolukemaurer:objinfo-no-codefrom
Conversation
lukemaurer
reviewed
Jun 28, 2024
Owner
lukemaurer
left a comment
There was a problem hiding this comment.
Oh nice, thanks! I just had one thought and then I guess the easiest is just to merge this into the other PR?
Author
|
This is a PR targeting the branch from which you submitted your PR, so if you merge it the original PR will be updated directly. |
Owner
Okay yeah, that's what I was thinking. Merging |
lukemaurer
added a commit
that referenced
this pull request
Jun 28, 2024
This exercises the separate `-no-approx` implementation from #2.
mshinwell
pushed a commit
to oxcaml/oxcaml
that referenced
this pull request
Jul 5, 2024
…o` (#2737) * Implement `-no-approx` and `-no-code` in flambda-backend `ocamlobjinfo` The old `-no-approx` and `-no-code` options are currently parsed but ignored. This is inconvenient, since the output for an flambda2 .cmx can be screenfuls long even for relatively small modules. This PR implements `-no-approx` by just suppressing .cmx export information altogether (roughly equivalent to what the old one did). Also implements `-no-code` by doing exactly the same thing as `-no-approx`. (Which does indeed mean there's no code.) * Also suppress zero-alloc info It's not as noisy as the full export info but it does make tests more sensitive. * Add conditional printing to Flambda_cmx_format * Better condition * Add a test case with `-no-code` but not `-no-approx` This exercises the separate `-no-approx` implementation from lukemaurer#2. --------- Co-authored-by: Vincent Laviron <vincent.laviron@gmail.com>
Ekdohibs
pushed a commit
to Ekdohibs/flambda-backend
that referenced
this pull request
Jul 5, 2024
…o` (oxcaml#2737) * Implement `-no-approx` and `-no-code` in flambda-backend `ocamlobjinfo` The old `-no-approx` and `-no-code` options are currently parsed but ignored. This is inconvenient, since the output for an flambda2 .cmx can be screenfuls long even for relatively small modules. This PR implements `-no-approx` by just suppressing .cmx export information altogether (roughly equivalent to what the old one did). Also implements `-no-code` by doing exactly the same thing as `-no-approx`. (Which does indeed mean there's no code.) * Also suppress zero-alloc info It's not as noisy as the full export info but it does make tests more sensitive. * Add conditional printing to Flambda_cmx_format * Better condition * Add a test case with `-no-code` but not `-no-approx` This exercises the separate `-no-approx` implementation from lukemaurer#2. --------- Co-authored-by: Vincent Laviron <vincent.laviron@gmail.com>
mshinwell
pushed a commit
to ocaml-flambda/ocaml-jst
that referenced
this pull request
Jul 15, 2024
…kend `ocamlobjinfo` (#2737) * Implement `-no-approx` and `-no-code` in flambda-backend `ocamlobjinfo` The old `-no-approx` and `-no-code` options are currently parsed but ignored. This is inconvenient, since the output for an flambda2 .cmx can be screenfuls long even for relatively small modules. This PR implements `-no-approx` by just suppressing .cmx export information altogether (roughly equivalent to what the old one did). Also implements `-no-code` by doing exactly the same thing as `-no-approx`. (Which does indeed mean there's no code.) * Also suppress zero-alloc info It's not as noisy as the full export info but it does make tests more sensitive. * Add conditional printing to Flambda_cmx_format * Better condition * Add a test case with `-no-code` but not `-no-approx` This exercises the separate `-no-approx` implementation from lukemaurer/flambda-backend#2. --------- Co-authored-by: Vincent Laviron <vincent.laviron@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I saw your PR (oxcaml#2737) and thought it was a shame that we didn't make the
-no-codeand-no-approxwork properly, so here is a proposal (on top of your branch) to make it more fine-grained.