only sign when releasing, to avoid gpg errors#4
Merged
lukecwik merged 2 commits intolukecwik:gradlefrom Apr 5, 2018
alanmyrvold:beam-gradle
Merged
only sign when releasing, to avoid gpg errors#4lukecwik merged 2 commits intolukecwik:gradlefrom alanmyrvold:beam-gradle
lukecwik merged 2 commits intolukecwik:gradlefrom
alanmyrvold:beam-gradle
Conversation
lukecwik
requested changes
Apr 5, 2018
| } | ||
| } | ||
|
|
||
| uploadArchives { |
Owner
There was a problem hiding this comment.
We can move this entire block into the isRelease above, then it won't even activate unless signing is needed.
| destination = file("$buildDir/generated-pom.xml") | ||
| } | ||
| tasks.publishMavenJavaPublicationToMavenLocal { | ||
| dependsOn project.tasks.signArchives |
Owner
There was a problem hiding this comment.
ditto on creating a new model { ... } block in isRelease() that contains these task dependencies.
lukecwik
approved these changes
Apr 5, 2018
lukecwik
pushed a commit
that referenced
this pull request
Apr 9, 2020
Ensure that we transcode between the (transformId, timerFamilyId) into the TimerData.timerId
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a machine without gpg private keys, I get errors when publishing
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue.mvn clean verifyto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.