Fix macOS 12 deprecation notice#5
Merged
lufia merged 1 commit intolufia:mainfrom Dec 4, 2021
dt:macos12-deprecation
Merged
Conversation
Owner
|
Hi @dt In macOS 11 runner, Would IOMainPort need to check if deployment target is macOS 12.0 or higher? |
Contributor
Author
|
Huh, whoops, looks like that conditional |
Previously compiling on Monterey would print a warning like this: ``` iostat_darwin.c:27:2: warning: 'IOMasterPort' is deprecated: first deprecated in macOS 12.0 [-Wdeprecated-declarations] /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/IOKit.framework/Headers/IOKitLib.h:132:1: note: 'IOMasterPort' has been explicitly marked deprecated here ``` This updates that usage to remove the warning.
Pull Request Test Coverage Report for Build 1535477136
💛 - Coveralls |
Owner
|
I checked above error is fixed. Thanks! @dt |
Owner
|
I've published v1.2.1 |
craig bot
pushed a commit
to cockroachdb/cockroach
that referenced
this pull request
Jan 4, 2022
74397: vendor: bump gopsutil and iostat to fix macOS 12 warnings r=dt a=dt Picks up upstream fixes for macOS 12 compiler warnings about deprecation of IOMasterPort: - lufia/iostat#5 - shirou/gopsutil#1191 Co-authored-by: David Taylor <tinystatemachine@gmail.com>
This was referenced Feb 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously compiling on Monterey would print a warning like this:
This updates that usage to remove the warning.