Merged
Conversation
Looks like MSVC does not like it and returns C2036 error. Needed to perform this change when integrating zstd into bazel to make it compile under Windows: bazelbuild/bazel@02e0515
Contributor
Author
|
@luben how hard would be to add direct support and CI for MSVC? Bazel seems to use it for compiling, so possibly would be good to have checks in here that it works as well. |
Contributor
Author
|
@luben friendly ping |
Owner
|
Hi, sorry for the delay - I was away fro a few weeks. LGTM |
Owner
|
Regarding the CI for MSVC - I have to spent some time on it. I recently moved the CI to GH actions so it should make it easier. |
glukasiknuro
added a commit
to glukasiknuro/bazel
that referenced
this pull request
Oct 29, 2020
New version contains luben/zstd-jni#140 which fixes issues with pointer arithmetic and makes the patch smaller.
glukasiknuro
added a commit
to glukasiknuro/bazel
that referenced
this pull request
Oct 29, 2020
New version contains luben/zstd-jni#140 which fixes issues with pointer arithmetic and makes the patch smaller.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like MSVC does not like it and returns C2036 error. Needed to
perform this change when integrating zstd into bazel to make it
compile under Windows:
bazelbuild/bazel@02e0515
See: bazelbuild/bazel#11968