Conversation
Only data-tree-print is needed now Co-authored-by: Luke Lau <luke_lau@icloud.com>
|
Related to #269 |
|
This doesn't build with GHC 8.4, 8.2, or 8.0. Do you know if it's an easy fix or not? |
|
@tfausak maybe i am not interpreting those builds correctly but they seem fail for ghc-8.10.2 and no for other versions?? EDIT: oh, i've just see you dropped support for those versions in the pr |
|
Afaics all changes in this pr was made under cpp conditions so it should not interfere with older ghc versions (module some error) |
|
I think some of the CPP changes looked like this: # if MIN_VERSION_ghc(8, 10, 1)
-- nothing
# else
some existing code
# endif |
| HsStatic{} -> do | ||
| -- TODO | ||
| briDocByExactInlineOnly "HsStatic{}" lexpr | ||
| #if MIN_VERSION_ghc(8,10,1) /* ghc-8.10.1 */ |
| HsTickPragma{} -> do | ||
| -- TODO | ||
| briDocByExactInlineOnly "HsTickPragma{}" lexpr | ||
| #if MIN_VERSION_ghc(8,10,1) /* ghc-8.10.1 */ |
|
Yeah, but it should no make fail previous ghc versions but make ghc-8.10.1 fail, no? Can you share the errors that were thrown for earlier versions? are there in the travis failed build for this pr? |
|
Sorry, my comment wasn't very helpful. Also apparently the links I shared earlier don't work anymore. I probably shouldn't have rebased #324. Here are actually usable links to the build failures: |
|
I'm closing this in favor of #324, which includes these commits. Please let me know if I've missed something! |
Continuing the work of @jneira in #305 , rebased