Support for ghc-8.10.1#305
Closed
jneira wants to merge 6 commits intolspitzner:masterfrom
jneira:ghc-8.10.1
Closed
Support for ghc-8.10.1#305jneira wants to merge 6 commits intolspitzner:masterfrom jneira:ghc-8.10.1
jneira wants to merge 6 commits intolspitzner:masterfrom
jneira:ghc-8.10.1
Conversation
Contributor
|
I've made it compile here in commit https://github.com/infinity0/brittany/commit/0807fc9b30eb9758dffdb87d2a9a9fa6a17a62b1 and it seems to work fine. Not entirely sure about my fixes though:
Everything else should be pretty reasonable. |
lukel97
reviewed
Aug 5, 2020
This was referenced Aug 5, 2020
Only data-tree-print is needed now Co-authored-by: Luke Lau <luke_lau@icloud.com>
more GHC 8.10.1 fixes
Contributor
|
@jneira Any chance I could get push access to this branch? I've rebased it and got it building on ghc-8.8 |
Contributor
Author
|
@bubba sure, feel free to open a new pr or alternatively you can do a pr against my branch |
Contributor
Author
|
Superseded by #312 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.