Skip to content
This repository was archived by the owner on Feb 6, 2025. It is now read-only.

Subclass SAMPProxyError from xmlrpc.Fault#5

Merged
cdeil merged 1 commit into
lpaioro:sampfrom
cdeil:SAMPProxyError
Sep 26, 2013
Merged

Subclass SAMPProxyError from xmlrpc.Fault#5
cdeil merged 1 commit into
lpaioro:sampfrom
cdeil:SAMPProxyError

Conversation

@cdeil

@cdeil cdeil commented Sep 25, 2013

Copy link
Copy Markdown
Collaborator

This should fix the last sphinx docs build warning and thus give astropy.vo.samp green light on travis-ci.

@pllim Thanks for the suggestion.
@lpaioro OK?

Comment thread astropy/vo/samp/errors.py

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need a pass command in the empty class.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I think pass is required

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if there's a docstring the pass is not needed.
Try it.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 @cdeil

@astrofrog

Copy link
Copy Markdown
Collaborator

Looks good!

cdeil added a commit that referenced this pull request Sep 26, 2013
Subclass SAMPProxyError from xmlrpc.Fault
@cdeil cdeil merged commit 130d2ed into lpaioro:samp Sep 26, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants