Fix setting WebP effort to 0 in constructor #3259#3261
Merged
lovell merged 1 commit intolovell:mainfrom Jun 17, 2022
Merged
Conversation
Owner
|
Would something like the following work to ensure we still support the deprecated const effort = is.defined(options.effort) ? options.effort : options.reductionEffort;Please can you remove the unrelated layout changes too. |
Contributor
Author
Ah, yes, I modified the code as if it were removed.
Yeah, my VS Code automatically formatted it for some reason. |
ef7133c to
093b584
Compare
Setting WebP effort to 0 in the constructor caused effort to use the default value of 4.
093b584 to
717b1dc
Compare
Owner
|
Brilliant, thank you! |
lovell
added a commit
that referenced
this pull request
Jun 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting WebP effort to 0 in the constructor caused the effort to use the
default value of 4.