Skip to content

Fix for 16-bit images output#2958

Closed
gforge wants to merge 11 commits intolovell:mainfrom
gforge:master
Closed

Fix for 16-bit images output#2958
gforge wants to merge 11 commits intolovell:mainfrom
gforge:master

Conversation

@gforge
Copy link
Copy Markdown
Contributor

@gforge gforge commented Oct 31, 2021

The suggested fix for issue #2934. Note that this causes warning of type:

(process:25977): GLib-GObject-WARNING **: 22:25:02.057: value "16" of type 'gint' is invalid or out of range for property 'bitdepth' of type 'gint'

@lovell lovell changed the base branch from master to main November 16, 2021 14:56
@lovell
Copy link
Copy Markdown
Owner

lovell commented Nov 16, 2021

I've updated the branch for this PR to use main, which provides libvips 8.12.0-rc1.

Please can you update the code to take an approach similar to #2934 (comment)

@gforge gforge changed the title Addition of pngBitdepth option to png Fix for 16-bit images output Nov 20, 2021
@gforge
Copy link
Copy Markdown
Contributor Author

gforge commented Nov 20, 2021

Thanks, I've updated the code with the Is16Bit function. The test still complains though with:

(process:38668): GLib-GObject-WARNING **: 17:16:45.992: value "16" of type 'gint' is invalid or out of range for property 'bitdepth' of type 'gint'

but I may have missed something when I compiled the library.

@lovell
Copy link
Copy Markdown
Owner

lovell commented Nov 21, 2021

Thanks for the updates, please can you rebase your branch against the upstream main rather than master.

@gforge gforge changed the base branch from main to master November 21, 2021 20:54
@gforge gforge changed the base branch from master to main November 21, 2021 20:54
@gforge
Copy link
Copy Markdown
Contributor Author

gforge commented Nov 21, 2021

Ok, I think I rebased it although I have to admit I have absolutely no idea if everything turned out fine.... at one time I think I did an empty commit and then stuff seemed to work but if it doesn't perhaps it's easier add the fixes manually.

lovell added a commit that referenced this pull request Nov 23, 2021
@lovell
Copy link
Copy Markdown
Owner

lovell commented Nov 23, 2021

Thank you, landed via 2deced0

@lovell lovell closed this Nov 23, 2021
Y2zz pushed a commit to Y2zz/sharp that referenced this pull request Feb 26, 2022
Y2zz pushed a commit to Y2zz/sharp that referenced this pull request Feb 26, 2022
martinj pushed a commit to aptoma/sharp that referenced this pull request Mar 31, 2022
martinj pushed a commit to aptoma/sharp that referenced this pull request Mar 31, 2022
@ashish-readwhere

This comment was marked as off-topic.

Repository owner locked and limited conversation to collaborators May 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants