Conversation
|
I've updated the branch for this PR to use Please can you update the code to take an approach similar to #2934 (comment) |
|
Thanks, I've updated the code with the
but I may have missed something when I compiled the library. |
|
Thanks for the updates, please can you rebase your branch against the upstream |
|
Ok, I think I rebased it although I have to admit I have absolutely no idea if everything turned out fine.... at one time I think I did an empty commit and then stuff seemed to work but if it doesn't perhaps it's easier add the fixes manually. |
|
Thank you, landed via 2deced0 |
The suggested fix for issue #2934. Note that this causes warning of type: