Add pyramid and tiling output options for TIFF images#1483
Merged
lovell merged 1 commit intolovell:masterfrom Dec 6, 2018
Merged
Add pyramid and tiling output options for TIFF images#1483lovell merged 1 commit intolovell:masterfrom
lovell merged 1 commit intolovell:masterfrom
Conversation
Owner
|
Fantastic, thank you Michael, this looks like the right approach and with lots of tests too. I should have some time to review this properly early next week. |
52896e1 to
6d510da
Compare
Contributor
Author
|
Thanks! I just realized that I left the trailing |
lovell
reviewed
Dec 4, 2018
…ple `is.object(options)` checks into an enclosing block
74f7e30 to
3eb132a
Compare
Owner
|
Marvellous, thank you for this Michael, it will be included in the next release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds the libvips
tiffsavepyramid,tile,tile_width, andtile_heightoptions to sharp'stiff()output format function to allow for the creation of multires/deep-zoom TIFFs.I wrestled with the idea of trying to overload the
tile()function to handletiffas another container type, but I stuck with the straightforward “do it more or less the way libvips does it” approach.