Skip to content

Fix test_set_only_work_in_hashable_types on Python 3.14#286

Merged
lovasoa merged 1 commit intolovasoa:masterfrom
cjwatson:py314-set-element-message
Mar 2, 2026
Merged

Fix test_set_only_work_in_hashable_types on Python 3.14#286
lovasoa merged 1 commit intolovasoa:masterfrom
cjwatson:py314-set-element-message

Conversation

@cjwatson
Copy link
Contributor

@cjwatson cjwatson commented Jan 7, 2026

python/cpython#132825 expanded this error message.

@noirbee
Copy link
Contributor

noirbee commented Mar 2, 2026

@cjwatson You'll need to rebase on master to get the changes in #284 , which should fix the CI failures

@cjwatson cjwatson force-pushed the py314-set-element-message branch from 9a2ea19 to f955ab1 Compare March 2, 2026 14:07
@cjwatson
Copy link
Contributor Author

cjwatson commented Mar 2, 2026

Thanks, done.

@lovasoa lovasoa merged commit 1601dab into lovasoa:master Mar 2, 2026
5 checks passed
@lovasoa
Copy link
Owner

lovasoa commented Mar 2, 2026

Can you open a new pr to add 3.14 to the test matrix to make sure noone reintroduces a behavior that breaks with newer pythons ?

@cjwatson cjwatson deleted the py314-set-element-message branch March 2, 2026 23:48
@cjwatson
Copy link
Contributor Author

cjwatson commented Mar 2, 2026

Done - #287.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants