Skip to content

Test on Python 3.13 and 3.14#287

Merged
lovasoa merged 3 commits intolovasoa:masterfrom
cjwatson:py314
Mar 5, 2026
Merged

Test on Python 3.13 and 3.14#287
lovasoa merged 3 commits intolovasoa:masterfrom
cjwatson:py314

Conversation

@cjwatson
Copy link
Contributor

@cjwatson cjwatson commented Mar 2, 2026

No description provided.

@cjwatson
Copy link
Contributor Author

cjwatson commented Mar 3, 2026

Getting this to work as the current matrix approach stands is impossible. pyupgrade 3.21.1 includes a fix needed for Python 3.14.1, but the same release also drops support for Python 3.9.

I'd suggest that pre-commit should be a separate CI job, run on fewer versions of Python (perhaps only one, but you'd have to tell me the correct policy to apply there). It doesn't need to be run using every version of Python that the package itself supports.

@lovasoa
Copy link
Owner

lovasoa commented Mar 3, 2026

agreed ! pre-commit should run only on a single widely used modern python (let's say 3.14), while the library tests themselves should run on the full matrix

@cjwatson
Copy link
Contributor Author

cjwatson commented Mar 4, 2026

OK, that seems to work now. You could probably also do a more general pre-commit autoupdate or similar (or even add something like pre-commit.ci or https://pre-commit.ci/lite.html to automate that), but I decided to keep my changes reasonably minimal for now.

Copy link
Owner

@lovasoa lovasoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you !

@lovasoa lovasoa merged commit 91f3977 into lovasoa:master Mar 5, 2026
8 checks passed
@cjwatson cjwatson deleted the py314 branch March 5, 2026 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants