Greptile Summary

This PR replaces the single-node Redis client (*redis.Client) with redis.UniversalClient throughout the codebase, enabling standalone, Sentinel, and Cluster modes through a unified interface. It also introduces a custom URL query-param parser (ParseUniversalURL) that maps a rich set of connection parameters (pool size, timeouts, routing flags, etc.) directly from the DSN, and adds new config fields (addrs, master_name, sentinel_username/password, route_by_latency, route_randomly, is_cluster_mode) with full backward compatibility for the deprecated addr field.

• Client layer (xredis/client.go): newUniversalOptions applies a clear precedence — URL body → URL query params → addr config → addrs config — before handing off to redis.NewUniversalClient, which auto-selects the right client type based on MasterName and IsClusterMode / address count.
• API surface (xcache, watcher): All public functions widened to redis.UniversalClient; NewRedisWithOptions updated to accept *redis.UniversalOptions.
• Documentation: New mode-specific examples and a full URL parameter reference table are added to both English and Chinese docs, but the Docker Compose deployment example block combines all three modes under a single YAML mapping, producing duplicate keys that most parsers will silently collapse to the last value.

Confidence Score: 3/5

The core client logic and backward compatibility are solid, but two pre-existing regressions from earlier review rounds remain unresolved in client.go, and the new documentation deployment example actively misleads users by placing all three mode configs under the same YAML block with conflicting duplicate keys.

The duplicate-key documentation bug is not merely cosmetic — a user following the deployment guide and copying the combined block would silently connect to cluster mode regardless of intent. The two client.go issues flagged in prior rounds (TLSInsecureSkipVerify regression for rediss:// + config flag, and undetected unknown URL params) also remain open. The implementation itself is architecturally sound and well-tested.

docs/en/deployment/configuration.md and docs/zh/deployment/configuration.md (duplicate-key deployment example); internal/pkg/xredis/client.go (open regressions from prior review rounds)

Important Files Changed

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[NewClient cfg] --> B[newUniversalOptions cfg]
    B --> C[ParseUniversalURL cfg.URL]
    C --> D{URL empty?}
    D -- yes --> E[return empty UniversalOptions]
    D -- no --> F[Parse scheme / host / path / query]
    F --> G{scheme rediss?}
    G -- yes --> H[Set TLSConfig MinTLS1.2]
    G -- no --> I[No TLS from URL]
    F --> J[Parse query params client_name db addrs sentinel_* pool_* timeouts...]
    H --> K[opts returned to newUniversalOptions]
    I --> K
    J --> K
    E --> K
    K --> L{cfg.Addr set?}
    L -- yes --> M[opts.Addrs = addr]
    L -- no --> N{cfg.Addrs set?}
    N -- yes --> O[opts.Addrs = addrs]
    N -- no --> P{opts.Addrs empty?}
    P -- yes --> Q[ERROR: addr required]
    P -- no --> R[Continue]
    M --> N
    O --> R
    R --> S[Override Username Password MasterName SentinelUsername/Password RouteByLatency RouteRandomly IsClusterMode DB]
    S --> T{cfg.TLS?}
    T -- yes --> U[Create/update TLSConfig Apply InsecureSkipVerify]
    T -- no --> V{cfg.TLSInsecureSkipVerify without TLSConfig?}
    U --> W[return opts]
    V -- yes --> X[ERROR: TLS required]
    V -- no --> W
    W --> Y[redis.NewUniversalClient opts]
    Y --> Z{opts.MasterName set?}
    Z -- yes --> ZA{opts.IsClusterMode?}
    ZA -- yes --> ZB[FailoverClusterClient]
    ZA -- no --> ZC[FailoverClient Sentinel]
    Z -- no --> ZD{IsClusterMode or len Addrs gt 1?}
    ZD -- yes --> ZE[ClusterClient]
    ZD -- no --> ZF[standalone Client]

_{Reviews (3): Last reviewed commit: "fix: remove deletion of query parameters..." | Re-trigger Greptile}