Greptile Summary

This PR fixes a nil-pointer panic in CreateModel and BulkCreateModels that occurred when input.Type was nil — the old code dereferenced the pointer unconditionally with SetType(*input.Type). The fix delegates field application to the ent-generated SetInput/Mutate path, which guards the Type field with a nil check and lets the schema-level Default("chat") supply the value when none is provided.

• model.go: Both create paths now use SetInput instead of individual Set* calls. The Remark field guard that follows is now redundant (already applied inside Mutate) and can be removed in both functions.
• model_validation_test.go: Two new integration tests assert the default-type behaviour for single and bulk creation; existing test fixtures are patched to include the required Icon, ModelCard, and Settings fields.

Confidence Score: 4/5

Safe to merge; the core logic change is correct and the new tests exercise the fixed path end-to-end.

The fix correctly removes an unconditional nil-pointer dereference on input.Type and relies on the well-established ent schema default. The only remaining issue is that the explicit Remark guard block is now dead code in both CreateModel and BulkCreateModels, since SetInput already applies Remark through Mutate — but this is harmless at runtime.

The redundant Remark handling in internal/server/biz/model.go (two places) is worth a quick cleanup pass.

Important Files Changed

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[CreateModel / BulkCreateModels] --> B{input.Type == nil?}
    B -- "Before fix" --> C["SetType(*input.Type) panic"]
    B -- "After fix" --> D["SetInput calls Mutate"]
    D --> E{Type != nil?}
    E -- yes --> F[m.SetType v]
    E -- no --> G[skip SetType]
    G --> H[ent schema Default 'chat' applied]
    F --> I[Save to DB]
    H --> I

_{Reviews (1): Last reviewed commit: "fix: should set default model type if ty..." | Re-trigger Greptile}