Conversation
Greptile SummaryThis PR fixes the model settings dialog so it no longer overflows the viewport on smaller screens or when content is tall. The dialog is now capped at 90% of the viewport height with the header and footer pinned, and the settings cards scroll within the remaining space.
Confidence Score: 5/5Safe to merge — the change is a self-contained layout fix with no logic, data, or API impact. The diff only adds Tailwind utility classes to make the dialog scrollable and height-bounded. No state management, data fetching, or business logic is touched, and the chosen flex-column pattern is a well-established approach for this type of constraint. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["DialogContent\nflex flex-col max-h-[90vh] overflow-hidden"] --> B["DialogHeader\nshrink-0"]
A --> C{isLoading?}
C -- "true" --> D["Spinner div\nflex items-center justify-center py-12"]
C -- "false" --> E["Content div\nflex-1 min-h-0 overflow-y-auto\n(scrolls within remaining space)"]
E --> F[Card: Fallback]
E --> G[Card: Query All Channel Models]
E --> H[Card: Blacklist Regex]
E --> I[Card: Default Model API]
E --> J[Card: Auto Reasoning Effort]
A --> K["DialogFooter\nshrink-0"]
K --> L[Cancel Button]
K --> M[Save Button]
Reviews (2): Last reviewed commit: "fix: model settings dialog, close #1716" | Re-trigger Greptile |
Uh oh!
There was an error while loading. Please reload this page.