Greptile Summary

This PR extends the model route condition system with two new filter fields — request_format (equality match against the inbound API format) and daily_time (time-window match with overnight wrap-around support) — and adds the necessary frontend UI, backend validation, and expression-engine wiring.

• Backend: xtime.ParseDailyTimeRange / DailyTimeWithin centralize time-range parsing (resolving the previously noted duplication). conditionToExpr emits a dailyTimeWithin(now, …) call for daily_time conditions, and now / request_format are injected into the evaluation context in filterResolvedCandidatesForRequest.
• Frontend: the FilterBuilder gains an options prop to render a dropdown for fixed-choice fields; request_format uses it, daily_time remains a free-text input. Client-side Zod validation for daily_time correctly rejects empty and equal-endpoint ranges, but the parallel check for request_format is missing an empty-string guard, allowing the form to submit when no format has been selected.
• Tests: both the xtime helpers and the orchestrator condition evaluator gain comprehensive unit tests covering normal, overnight, edge-case, and error scenarios.

Confidence Score: 4/5

Safe to merge after fixing the frontend validation gap for empty request_format values.

The backend logic is solid — time-range parsing, overnight wrap-around, operator validation, and expression generation are all correct and well-tested. The one defect is on the frontend: when a user adds a request_format condition but never picks a format, the value is an empty string that passes Zod validation and reaches the API, which returns a server-side error instead of an inline field error. Every other new condition type handles the empty state client-side; request_format is missing that guard.

frontend/src/features/models/components/models-association-dialog.tsx — the request_format condition validation block needs an empty-string check alongside the typeof guard.

Important Files Changed

Sequence Diagram

sequenceDiagram
    participant Client
    participant APIHandler
    participant Orchestrator
    participant ConditionEval as objects.Evaluate
    participant XTime as xtime.DailyTimeWithin

    Client->>APIHandler: POST /v1/... (sets req.APIFormat)
    APIHandler->>Orchestrator: filterResolvedCandidatesForRequest(req)
    Orchestrator->>Orchestrator: "requestFormat = req.APIFormat"
    Orchestrator->>Orchestrator: "now = time.Now()"
    loop For each association candidate
        Orchestrator->>ConditionEval: "Evaluate(condition, {prompt_tokens, stream, request_format, now})"
        alt daily_time condition
            ConditionEval->>XTime: DailyTimeWithin(now, HH:mm-HH:mm)
            XTime-->>ConditionEval: bool
        else request_format condition
            ConditionEval->>ConditionEval: "request_format == value"
        end
        ConditionEval-->>Orchestrator: bool
    end
    Orchestrator-->>APIHandler: filtered candidates

_{Reviews (2): Last reviewed commit: "feat: add advanced model route condition..." | Re-trigger Greptile}