Conversation
Greptile SummaryThis PR fixes issue #1701 by adding
Confidence Score: 3/5The dialog scroll fix is straightforward but the accidentally committed The
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Dialog opens] --> B[DialogContent\nmax-h-90vh + overflow-y-auto]
B --> C[DialogHeader\nfixed at top? No — scrollable]
B --> D[Content div\nCards + Form fields]
B --> E[DialogFooter\nSave / Cancel buttons]
D -->|Content exceeds 90vh| F[Scrollbar appears]
F -->|User scrolls down| G[DialogFooter scrolls out of view\n⚠️ Buttons hidden]
F -->|User scrolls up| H[DialogHeader scrolls out of view\n⚠️ Title hidden]
style G fill:#fef3c7,stroke:#d97706
style H fill:#fef3c7,stroke:#d97706
Reviews (1): Last reviewed commit: "fix: scroll for the channel rate limit d..." | Re-trigger Greptile |
| allowBuilds: | ||
| '@swc/core': set this to true or false | ||
| esbuild: set this to true or false |
There was a problem hiding this comment.
Both allowBuilds entries contain the literal string "set this to true or false" rather than true or false. pnpm will either reject these values during schema validation or behave unexpectedly, potentially blocking postinstall scripts for @swc/core and esbuild — breaking the build for everyone who runs pnpm install. This file appears to be an unfinished template that was accidentally included in this PR.
| }} | ||
| > | ||
| <DialogContent className='sm:max-w-2xl'> | ||
| <DialogContent className='max-h-[90vh] overflow-y-auto sm:max-w-2xl'> |
There was a problem hiding this comment.
overflow-y-auto is applied directly to the DialogContent wrapper, which means the DialogFooter (containing the Save/Cancel buttons) is part of the scrollable area and will disappear when the user scrolls down. On a short viewport a user filling in the lower fields will have to scroll back up to find the action buttons. A common fix is to apply overflow-y-auto only to the middle content div and keep the header and footer outside the scroll region.
| allowBuilds: | ||
| '@swc/core': set this to true or false | ||
| esbuild: set this to true or false |
There was a problem hiding this comment.
🔴 pnpm-workspace.yaml has placeholder strings instead of boolean values, blocking native builds
The allowBuilds entries in frontend/pnpm-workspace.yaml contain the literal placeholder strings set this to true or false instead of actual boolean values (true/false). pnpm auto-generates this file with placeholder text when it encounters packages with postinstall scripts, expecting the developer to replace them. With these string values, pnpm will either reject the config during pnpm install or treat the non-true strings as falsy and block native build scripts for @swc/core and esbuild. Since Vite depends on esbuild for bundling, blocking its postinstall (which downloads the platform-specific binary) will break the frontend build pipeline.
| allowBuilds: | |
| '@swc/core': set this to true or false | |
| esbuild: set this to true or false | |
| allowBuilds: | |
| '@swc/core': true | |
| esbuild: true | |
Was this helpful? React with 👍 or 👎 to provide feedback.
Uh oh!
There was an error while loading. Please reload this page.