Greptile Summary

This PR fixes a cache-refresh issue by running the onSwap callback synchronously (with proper logging) and adding a 5-second timeout to exec.Shutdown in both TokenProvider and DeviceFlowProvider, preventing indefinite blocking of the worker goroutine. It also corrects the test's data race by moving the atomic increment to after the plain writes.

• cache.go: Adds log.Debug bookends around the synchronous onSwap invocation and a comment explaining why it runs on the worker goroutine with bounded latency.
• token_provider.go / device_flow_provider.go: Replaces the unbounded context.Background() passed to exec.Shutdown with a context.WithTimeout of 5 s, matching the stated "bounded by timeouts" contract.
• cache_test.go: Moves atomic.AddInt32 to after the plain oldValue/newValue writes so the atomic increment acts as a release-store, fixing the data race flagged in the previous review.

Confidence Score: 5/5

Safe to merge — all changes are additive logging, a bounded shutdown timeout, and a test race fix.

All four files contain narrow, well-scoped changes: two providers gain a 5-second shutdown timeout that prevents the worker goroutine from blocking indefinitely, the cache gets observability log lines with no logic change, and the test correctly sequences the atomic increment after the plain writes to eliminate the data race from the prior review. No existing behavior is altered in a way that could regress.

No files require special attention.

Important Files Changed

Sequence Diagram

sequenceDiagram
    participant W as Worker goroutine
    participant LI as loadInternal
    participant OS as onSwap callback
    participant SAR as StopAutoRefresh

    W->>LI: doRefresh(ctx, force)
    LI->>LI: "swap c.data & c.lastUpdate"
    LI->>OS: log.Debug "onSwap starting"
    LI->>OS: c.onSwap(old, newData)
    OS->>SAR: exec.Shutdown(ctx 5s timeout)
    SAR-->>OS: shutdown complete / timeout
    OS-->>LI: return
    LI->>LI: log.Debug "onSwap completed"
    LI->>LI: log.Info "cache refreshed"
    LI-->>W: return err

_{Reviews (2): Last reviewed commit: "fix: cache not refresh in some cache" | Re-trigger Greptile}