Skip to content

fix(channels): import Qiniu icon in config_channels#1613

Merged
looplj merged 1 commit into
looplj:unstablefrom
suixinio:fix/qiniu-import-config-channels
May 8, 2026
Merged

fix(channels): import Qiniu icon in config_channels#1613
looplj merged 1 commit into
looplj:unstablefrom
suixinio:fix/qiniu-import-config-channels

Conversation

@suixinio

@suixinio suixinio commented May 8, 2026

Copy link
Copy Markdown
Contributor

Summary

  • CHANNEL_CONFIGS.qiniu references Qiniu from @lobehub/icons, but the import was added only in config_providers.ts and missed in config_channels.ts.
  • Throws ReferenceError: Qiniu is not defined at module evaluation, crashing every page that imports config_channels (channels list, project requests, etc.). React's error boundary catches it and shows the generic error page.
  • One-line fix: add Qiniu to the @lobehub/icons import block in config_channels.ts.

Regression introduced in #1612.

Test plan

  • pnpm build no longer fails / produces a runtime ReferenceError
  • Verified on a deployment running the fix: /channels and /project/requests render again

CHANNEL_CONFIGS.qiniu references the Qiniu icon but the upstream PR
that added Qiniu support imported it only in config_providers.ts and
forgot the matching import here. The bundled module throws
"ReferenceError: Qiniu is not defined" at evaluation, which crashes
any page that imports config_channels (channels list, project
requests, etc).
Copilot AI review requested due to automatic review settings May 8, 2026 14:50
@greptile-apps

greptile-apps Bot commented May 8, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This one-line fix adds the missing Qiniu import from @lobehub/icons in config_channels.ts, which was causing a ReferenceError: Qiniu is not defined at module evaluation time and crashing every page that imports this file.

  • The symbol Qiniu was referenced at line 142 (icon: Qiniu) but never imported; the import existed only in config_providers.ts from the previous PR (feat: add Qiniu provider support #1612).
  • Adding Qiniu to the named import block is the correct and complete fix — no other changes are needed.

Confidence Score: 5/5

Safe to merge — the change is a single named import addition that directly resolves the crash described in the PR.

The change adds exactly one missing import that was already expected at line 142. There is no logic change, no new code path, and the fix aligns perfectly with how every other icon in the same file is handled.

No files require special attention.

Important Files Changed

Filename Overview
frontend/src/features/channels/data/config_channels.ts Adds the missing Qiniu named import from @lobehub/icons; the symbol was already referenced at line 142 but not imported, causing a ReferenceError at module load time.

Sequence Diagram

sequenceDiagram
    participant Browser
    participant Module as config_channels.ts
    participant Icons as @lobehub/icons

    Note over Module,Icons: Before fix
    Browser->>Module: import config_channels
    Module->>Icons: "import { ..., Qiniu (missing), ... }"
    Icons-->>Module: ReferenceError: Qiniu is not defined
    Module-->>Browser: Module evaluation crash → error page

    Note over Module,Icons: After fix
    Browser->>Module: import config_channels
    Module->>Icons: "import { ..., Qiniu, ... }"
    Icons-->>Module: Qiniu component resolved ✓
    Module-->>Browser: CHANNEL_CONFIGS exported successfully
Loading

Reviews (1): Last reviewed commit: "fix(channels): import Qiniu icon in conf..." | Re-trigger Greptile

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes a runtime crash in the channels UI by adding the missing Qiniu icon import to config_channels.ts, aligning it with the existing CHANNEL_CONFIGS.qiniu usage and the provider config.

Changes:

  • Add Qiniu to the @lobehub/icons import list in config_channels.ts to prevent ReferenceError: Qiniu is not defined during module evaluation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the Qiniu channel to the configuration imports in frontend/src/features/channels/data/config_channels.ts. There were no review comments provided for this change, and I have no further feedback to provide.

@looplj looplj merged commit d5d0d27 into looplj:unstable May 8, 2026
7 of 8 checks passed
looplj pushed a commit that referenced this pull request May 8, 2026
CHANNEL_CONFIGS.qiniu references the Qiniu icon but the upstream PR
that added Qiniu support imported it only in config_providers.ts and
forgot the matching import here. The bundled module throws
"ReferenceError: Qiniu is not defined" at evaluation, which crashes
any page that imports config_channels (channels list, project
requests, etc).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants