fix(channels): import Qiniu icon in config_channels#1613
Conversation
CHANNEL_CONFIGS.qiniu references the Qiniu icon but the upstream PR that added Qiniu support imported it only in config_providers.ts and forgot the matching import here. The bundled module throws "ReferenceError: Qiniu is not defined" at evaluation, which crashes any page that imports config_channels (channels list, project requests, etc).
Greptile SummaryThis one-line fix adds the missing
Confidence Score: 5/5Safe to merge — the change is a single named import addition that directly resolves the crash described in the PR. The change adds exactly one missing import that was already expected at line 142. There is no logic change, no new code path, and the fix aligns perfectly with how every other icon in the same file is handled. No files require special attention. Important Files Changed
Sequence DiagramsequenceDiagram
participant Browser
participant Module as config_channels.ts
participant Icons as @lobehub/icons
Note over Module,Icons: Before fix
Browser->>Module: import config_channels
Module->>Icons: "import { ..., Qiniu (missing), ... }"
Icons-->>Module: ReferenceError: Qiniu is not defined
Module-->>Browser: Module evaluation crash → error page
Note over Module,Icons: After fix
Browser->>Module: import config_channels
Module->>Icons: "import { ..., Qiniu, ... }"
Icons-->>Module: Qiniu component resolved ✓
Module-->>Browser: CHANNEL_CONFIGS exported successfully
Reviews (1): Last reviewed commit: "fix(channels): import Qiniu icon in conf..." | Re-trigger Greptile |
There was a problem hiding this comment.
Pull request overview
Fixes a runtime crash in the channels UI by adding the missing Qiniu icon import to config_channels.ts, aligning it with the existing CHANNEL_CONFIGS.qiniu usage and the provider config.
Changes:
- Add
Qiniuto the@lobehub/iconsimport list inconfig_channels.tsto preventReferenceError: Qiniu is not definedduring module evaluation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
CHANNEL_CONFIGS.qiniu references the Qiniu icon but the upstream PR that added Qiniu support imported it only in config_providers.ts and forgot the matching import here. The bundled module throws "ReferenceError: Qiniu is not defined" at evaluation, which crashes any page that imports config_channels (channels list, project requests, etc).
Summary
CHANNEL_CONFIGS.qiniureferencesQiniufrom@lobehub/icons, but the import was added only inconfig_providers.tsand missed inconfig_channels.ts.ReferenceError: Qiniu is not definedat module evaluation, crashing every page that importsconfig_channels(channels list, project requests, etc.). React's error boundary catches it and shows the generic error page.Qiniuto the@lobehub/iconsimport block inconfig_channels.ts.Regression introduced in #1612.
Test plan
pnpm buildno longer fails / produces a runtimeReferenceError/channelsand/project/requestsrender again