Always use Content-Type application/json#56
Closed
andrewvc wants to merge 1 commit intologstash-plugins:masterfrom
Closed
Always use Content-Type application/json#56andrewvc wants to merge 1 commit intologstash-plugins:masterfrom
andrewvc wants to merge 1 commit intologstash-plugins:masterfrom
Conversation
This is what ES wants/expects
karmi
added a commit
to elastic/elasticsearch-ruby
that referenced
this pull request
Feb 7, 2017
…' header In future, Elasticsearch will require specifying the format of data which is being sent (eg. when indexing a document). Current versions of Elasticsearch will start to print a warning to the deprecation log. A default value 'application/json' for the 'Content-Type' header has been added to prevent the deprecation messages and to be prepared for the requirement in next major version of Elasticsearch. See: elastic/elasticsearch#22691 Related: * c22ec89 * logstash-plugins/logstash-input-elasticsearch#55 * logstash-plugins/logstash-input-elasticsearch#56 * elastic/elasticsearch#22691 Closes #400
karmi
added a commit
to elastic/elasticsearch-ruby
that referenced
this pull request
Feb 7, 2017
…' header In future, Elasticsearch will require specifying the format of data which is being sent (eg. when indexing a document). Current versions of Elasticsearch will start to print a warning to the deprecation log. A default value 'application/json' for the 'Content-Type' header has been added to prevent the deprecation messages and to be prepared for the requirement in next major version of Elasticsearch. See: elastic/elasticsearch#22691 Related: * c22ec89 * logstash-plugins/logstash-input-elasticsearch#55 * logstash-plugins/logstash-input-elasticsearch#56 * elastic/elasticsearch#22691 Closes #400
karmi
added a commit
to elastic/elasticsearch-ruby
that referenced
this pull request
Feb 7, 2017
…nticore adapter The Manticore adapter doesn't handle the `transport_options` in the same way as the Faraday and Curb adapters. The addition of a default 'Content-Type' header in 76f8679 (#400) didn't work then, and this patch fixes it. Related: * #400 * logstash-plugins/logstash-input-elasticsearch#55 * logstash-plugins/logstash-input-elasticsearch#56
karmi
added a commit
to elastic/elasticsearch-ruby
that referenced
this pull request
Feb 7, 2017
…nticore adapter The Manticore adapter doesn't handle the `transport_options` in the same way as the Faraday and Curb adapters. The addition of a default 'Content-Type' header in 76f8679 (#400) didn't work then, and this patch fixes it. Related: * #400 * logstash-plugins/logstash-input-elasticsearch#55 * logstash-plugins/logstash-input-elasticsearch#56
Contributor
|
Is this PR still needed with the fix in upstream elasticsearch-ruby? |
picandocodigo
pushed a commit
to elastic/elastic-transport-ruby
that referenced
this pull request
Jun 7, 2021
…' header In future, Elasticsearch will require specifying the format of data which is being sent (eg. when indexing a document). Current versions of Elasticsearch will start to print a warning to the deprecation log. A default value 'application/json' for the 'Content-Type' header has been added to prevent the deprecation messages and to be prepared for the requirement in next major version of Elasticsearch. See: elastic/elasticsearch#22691 Related: * c22ec891b0be0e3e8f3c10fd7844adfbd2d608ed * logstash-plugins/logstash-input-elasticsearch#55 * logstash-plugins/logstash-input-elasticsearch#56 * elastic/elasticsearch#22691 Closes #400
picandocodigo
pushed a commit
to elastic/elastic-transport-ruby
that referenced
this pull request
Jun 7, 2021
…nticore adapter
The Manticore adapter doesn't handle the `transport_options` in the same way
as the Faraday and Curb adapters.
The addition of a default 'Content-Type' header in 76f86793cde0a0e7e816a743c73f69002a53483e
(#400) didn't work then, and this patch fixes it.
Related:
* elastic/elasticsearch-ruby#400
* logstash-plugins/logstash-input-elasticsearch#55
* logstash-plugins/logstash-input-elasticsearch#56
renaperes824
added a commit
to renaperes824/ruby-elastic-transport
that referenced
this pull request
Sep 12, 2022
…' header In future, Elasticsearch will require specifying the format of data which is being sent (eg. when indexing a document). Current versions of Elasticsearch will start to print a warning to the deprecation log. A default value 'application/json' for the 'Content-Type' header has been added to prevent the deprecation messages and to be prepared for the requirement in next major version of Elasticsearch. See: elastic/elasticsearch#22691 Related: * c22ec891b0be0e3e8f3c10fd7844adfbd2d608ed * logstash-plugins/logstash-input-elasticsearch#55 * logstash-plugins/logstash-input-elasticsearch#56 * elastic/elasticsearch#22691 Closes #400
renaperes824
added a commit
to renaperes824/ruby-elastic-transport
that referenced
this pull request
Sep 12, 2022
…nticore adapter
The Manticore adapter doesn't handle the `transport_options` in the same way
as the Faraday and Curb adapters.
The addition of a default 'Content-Type' header in 76f86793cde0a0e7e816a743c73f69002a53483e
(#400) didn't work then, and this patch fixes it.
Related:
* elastic/elasticsearch-ruby#400
* logstash-plugins/logstash-input-elasticsearch#55
* logstash-plugins/logstash-input-elasticsearch#56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is what ES wants/expects