fix: match paste of x.com links for twitter #11942
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
d081be9 to
d2c4097
Compare
tiensonqin
approved these changes
Jun 15, 2025
Contributor
tiensonqin
left a comment
There was a problem hiding this comment.
Works great, thanks for the fix! 🚀
katafrakt
added a commit
to katafrakt/logseq
that referenced
this pull request
Jun 15, 2025
There was a bug that pasting link from domains ending with x.com was parsed as a ex-Twitter link. But this was not necessarily a link from this social network. This commit changes the regex to better detect proper X links and tell them apart from non-X links. This is a port of an original PR logseq#11942
katafrakt
added a commit
to katafrakt/logseq
that referenced
this pull request
Jun 15, 2025
There was a bug that pasting link from domains ending with x.com was parsed as a ex-Twitter link. But this was not necessarily a link from this social network. This commit changes the regex to better detect proper X links and tell them apart from non-X links. This is a port of an original PR logseq#11942
2 tasks
This was referenced Aug 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11935
Match with existing regex in code to ensure its valid twitter link when pasting.