Enhance: Introduce customizable close window shortcut #10190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2e8ce51 to
dd9fd20
Compare
Collaborator
|
non-blocking: The developer tools window cannot be closed with mod+w. I prefer the old style of "mod+w". |
dd9fd20 to
b1b921c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing on #10096. Now that the default keyboard behavior is deactivated, users will be able to remove the introduced binding if they want to. I moved the window handlers to a dedicated file to clean up the code. The binding was added to
:shortcut.handler/global-non-editing-onlyto avoid closing the window while editing, which might be questionable. I can move it to global bindings if that's not what we want. I also suppressed some random infer build warnings here 6d15483.Resolves #10176