Enhance: Disable close window shortcut #10096
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
I just realized that we don't have to override |
andelf
approved these changes
Aug 25, 2023
Contributor
|
@sprocketc, how to close only one Logseq window now? ⌘Q quits whole application 🤷♂️ |
Collaborator
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on this comment, we override the default Window and File menu to disable the close window shortcut on all platforms. This binding seems to annoy a lot of users, and multi-window workflow is not properly supported yet. The menu item itself is preserved.
CmdOrCtrl+Qwill now be the only shortcut that closes the window.CmdOrCtrl+Wis free to be used by plugins or Logseq to dismiss panes etc.Resolves #3967