Demonstrate mode/UID/GID parsing ambiguity#561
Conversation
Since we accept numeric UID/GID, we are never really sure which of the three optional numeric parameters to "create" or "createolddir" is really given. Tried to update manual page to say which parameters and optional and in which order.
|
It seems historically Since the user and group strings are always converted to ids with regard to base 10 and the create mode normally should be specified as an octal value a leading But I think these nuances can get very tricky so maybe it's best to come up with a new syntax altogether? |
|
I think the test in this pull request does not pass, so the first two numbers (if the first one is parseable octally) become mode and the owner. So I think we have a bug now since numeric UIDs have been introduced. We might need to fix it |
Restore old behavior when one or two arguments are specified for the create and createolddir directives. This was broken with the introduction of numeric uid/gid support. Fixes: logrotate#561
Restore old behavior when one or two arguments are specified for the create and createolddir directives. This was broken with the introduction of numeric uid/gid support. Fixes: logrotate#561
Restore old behavior when one or two arguments are specified for the create and createolddir directives. This was broken with the introduction of numeric uid/gid support. Fixes: #561
Since we accept numeric UID/GID, we are never
really sure which of the three optional
numeric parameters to "create" or "createolddir"
is really given.
Tried to update manual page to say which
parameters and optional and in which order.