Skip to content

log: unify handling of log levels#449

Merged
kdudka merged 1 commit intologrotate:masterfrom
kdudka:log-levels
Jun 2, 2022
Merged

log: unify handling of log levels#449
kdudka merged 1 commit intologrotate:masterfrom
kdudka:log-levels

Conversation

@kdudka
Copy link
Member

@kdudka kdudka commented May 27, 2022

Use MESS_WARN instead of MESS_NORMAL and make it always use the warning: prefix. Also drop MESS_VERBOSE, which was not set anywhere.

kdudka added a commit to kdudka/logrotate that referenced this pull request May 27, 2022
Use MESS_WARN instead of MESS_NORMAL and make it always use
the `warning:` prefix.  MESS_WARN is now mapped to LOG_WARNING
for syslog.

Also drop MESS_VERBOSE, which was not set anywhere.

Closes: logrotate#449
kdudka added a commit to kdudka/logrotate that referenced this pull request May 27, 2022
Use MESS_WARN instead of MESS_NORMAL and make it always use
the `warning:` prefix.  MESS_WARN is now mapped to LOG_WARNING
for syslog.

Also drop MESS_VERBOSE, which was not set anywhere.

Closes: logrotate#449
kdudka added a commit to kdudka/logrotate that referenced this pull request May 30, 2022
Use MESS_WARN instead of MESS_NORMAL and make it always use
the `warning:` prefix.  MESS_WARN is now mapped to LOG_WARNING
for syslog.

Also drop MESS_VERBOSE, which was not set anywhere.

Closes: logrotate#449
@kdudka kdudka requested a review from cgzones May 30, 2022 06:32
@cgzones
Copy link
Member

cgzones commented Jun 1, 2022

Does this one supersedes #239?

@kdudka
Copy link
Member Author

kdudka commented Jun 2, 2022

Yes, good point, except that this pull request does not add the debug: prefix, which is probably fine.

Use MESS_WARN instead of MESS_NORMAL and make it always use
the `warning:` prefix.  MESS_WARN is now mapped to LOG_WARNING
for syslog.

Also drop MESS_VERBOSE, which was not set anywhere.

Closes: logrotate#239
Closes: logrotate#449
@kdudka kdudka merged commit 7b1fa32 into logrotate:master Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants