Allow to pass a home-relative path to include#326
Closed
cgzones wants to merge 1 commit intologrotate:masterfrom
Closed
Allow to pass a home-relative path to include#326cgzones wants to merge 1 commit intologrotate:masterfrom
cgzones wants to merge 1 commit intologrotate:masterfrom
Conversation
Member
|
This definitely needs to be documented. Should we take the value from |
kdudka
requested changes
May 28, 2020
Member
kdudka
left a comment
There was a problem hiding this comment.
Thanks for the update! Please keep the code ISO C90 compliant:
config.c: In function ‘readConfigFile’:
config.c:1495:33: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
1495 | const struct passwd *pwd = getpwuid(getuid());
| ^~~~~
config.c:1504:29: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
1504 | char *new_key = NULL;
| ^~~~
Please remove the dead dead assignment new_key = NULL; at end of the scope of new_key.
Accept a path with leading "~/" in include directives and replace with
either the environment variable ${HOME} (if existent) or the initial
working directory of the user.
Member
Author
|
Updated. Can you please either mention to keep the code ISO C90 compliant, e.g. in |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accept a path with leading "~/" in include directives and replace with the environment variable ${HOME} (if existent).