configure.ac: compile with -Wdeclaration-after-statement#328
Closed
kdudka wants to merge 2 commits intologrotate:masterfrom
Closed
configure.ac: compile with -Wdeclaration-after-statement#328kdudka wants to merge 2 commits intologrotate:masterfrom
kdudka wants to merge 2 commits intologrotate:masterfrom
Conversation
... to make sure we keep the code ISO C90 compliant
-Wdeclaration-after-statement
Member
|
I think the current code is not quite ISO C90 compliant. and |
Member
Author
|
Good point. On the other hand, nobody has complained about these warnings for a couple of releases. Are you suggesting to reword the commit message or rather drop this completely? |
Member
|
I am fine with the commits, just wanted to make sure there are no wrong expectations. |
Member
Author
|
I see it is not perfect but it can still be useful in some cases, so merging it. Thanks for review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... to make sure we keep the code ISO C90 compliant