switch_user_permanently: skip switchback check if switched to root#319
Closed
cgzones wants to merge 4 commits intologrotate:masterfrom
Closed
switch_user_permanently: skip switchback check if switched to root#319cgzones wants to merge 4 commits intologrotate:masterfrom
cgzones wants to merge 4 commits intologrotate:masterfrom
Conversation
Allow switching only the real group (not the user) with a configuration
like `su root somegroup`.
E.g. mailman uses `su root list`, which currently fails with:
error: failed to switch user permanently, able to switch back
error: failed to compress log /var/log/mailman/qrunner.1
Fixes: a0b05e4 ("switch_user_permanently: check if switchback is possible")
…nfiguration specified ones
Print pid to distinguish processes. Print previous effective ids.
Member
|
Merging, thanks! |
kdudka
pushed a commit
that referenced
this pull request
Apr 8, 2020
…nfiguration specified ones Closes: #319
kdudka
pushed a commit
that referenced
this pull request
Apr 8, 2020
Print pid to distinguish processes. Print previous effective ids. Closes: #319
kdudka
pushed a commit
that referenced
this pull request
Apr 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
switch_user_permanently: skip switchback check if switched to root
Allow switching only the real group (not the user) with a configuration
like
su root somegroup.E.g. mailman uses
su root list, which currently fails with:error: failed to switch user permanently, able to switch backerror: failed to compress log /var/log/mailman/qrunner.1switch_user_permanently: add sanity check that effective ids match configuration specified ones
switch_user*: improve debug logging
Print pid to distinguish processes.
Print previous effective ids.
rotateLogSet: call switch_user_back on early return