323370043: Added future dependency for latest version of pefile #641#1335
Closed
joachimmetz wants to merge 1 commit intolog2timeline:masterfrom
Closed
323370043: Added future dependency for latest version of pefile #641#1335joachimmetz wants to merge 1 commit intolog2timeline:masterfrom
joachimmetz wants to merge 1 commit intolog2timeline:masterfrom
Conversation
thinrope
added a commit
to thinrope/plaso
that referenced
this pull request
Apr 8, 2024
In 2017 this dependecy was added via log2timeline#1335 for pefile, but currently it supports python3 properly, so not needed. I tried to remove all references to pythion4-future module (only 2 in code and a few in the build/install frameworks).
thinrope
added a commit
to thinrope/plaso
that referenced
this pull request
Apr 8, 2024
In 2017 this dependecy was added via log2timeline#1335 for pefile, but currently it supports python3 properly, so not needed. I tried to remove all references to python3-future module (only 2 in code and a few in the build/install frameworks).
thinrope
added a commit
to thinrope/plaso
that referenced
this pull request
Apr 8, 2024
In 2017 this dependency was added via log2timeline#1335 for pefile, but currently it supports python3 properly, so not needed. I tried to remove all references to python3-future module (only 2 in code and a few in the build/install frameworks).
3 tasks
thinrope
added a commit
to thinrope/plaso
that referenced
this pull request
Apr 9, 2024
In 2017 this dependency was added via log2timeline#1335 for pefile, but after erocarrera/pefile#349 merged in pefile-2023.2.7 it is not needed anymore. Also bump pefile minimum version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code review: 323370043: Added future dependency for latest version of pefile #641