Merged
Conversation
… along to GeoWave via QueryOptions
| } | ||
|
|
||
| final ByteBuffer buf = ByteBuffer.allocate(20 + authBytes.length + aSize + iSize + fieldIdsBytesNeeded); | ||
| buf.putInt((fieldIdsBytesNeeded > 0) ? 1 : 0); |
Contributor
There was a problem hiding this comment.
Do we need the extra int, or can we just place a 0 if the field id list is emty?
Contributor
Author
There was a problem hiding this comment.
Don't need the extra int. I will clean this up.
Contributor
|
Agreed. Once we address these comments We can move forward. Steve and I were discussing potentially make a variant to the whole feature data adapter further reduce the volume from the server to the client. At some point, all of us did discuss a better method to compress the field/value bytes, using a bitmask--bits coincide with feature attribute names as they are in ordered within the simplefeaturetype). I think the next is benchmark this approach and then make the incremental changes to determine they value they provide. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #615
SharedVisibilitySplittingIterator decomposes composite fieldIds on the tablet server, which replaces the old approach of doing this twice (once client side in AccumuloUtils and also in QueryFilterIterator)
FieldFilter filters only those fieldIds that were specified in QueryOptions
AttributesSubsetQueryIT tests both server side and client side filtering functionality
We also support subsetting through GeoTools Query via propertyNames. GeoToolsAttributesSubsetTest verifies this functionality