Merged
Conversation
| private transient CoordinateReferenceSystem crs = null; | ||
| private transient GeometryCalculations calculator; | ||
| private DimensionExtractor<T> dimensionExtractor; | ||
| protected DimensionExtractor<T> dimensionExtractor; |
Contributor
Author
There was a problem hiding this comment.
Will make sense in the next commit. It slipped in this one. I just noticed it. Recommend letting it go through.
Contributor
|
so this is just a cherry-pick? it seems ok, a lot of changes that I don't necessarily need to review again assuming it is just a cherry-pick? |
Contributor
Author
|
Correct just cherry picking. The change is that I removed per attribute visibility from the whole feature data adapter. It was not not used. Also, I collapsed the Kryo adapter into the whole feature adapter. The kryo class was not serving any purpose. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.