GEOWAVE-620. Fix GeoServer pluggin WFS-T startIndex query constraint#622
Merged
GEOWAVE-620. Fix GeoServer pluggin WFS-T startIndex query constraint#622
Conversation
rfecher
added a commit
that referenced
this pull request
Feb 12, 2016
GEOWAVE-620. Fix GeoServer pluggin WFS-T startIndex query constraint
| final Long max = (limit != null) ? | ||
| limit.longValue() + (startIndex == null ? 0 : startIndex.longValue()) : null; | ||
| // limit only used if less than an integer max value. | ||
| limit = (max != null && max.longValue() > Integer.MAX_VALUE) ? max.intValue() : null; |
Contributor
There was a problem hiding this comment.
shouldn't this be limit = (max != null && max.longValue() < Integer.MAX_VALUE) ? max.intValue() : null; (less than Integer.MAX_VALUE, not greater than) ?
Contributor
There was a problem hiding this comment.
I'm sorry I merged and didn't catch this...
I'm pretty sure you're right.
Contributor
|
Suggest adding a test for this to one of the existing Integration Tests. If nothing else, should prevent us from unknowingly breaking it in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.