GEOWAVE-398 & GEOWAVE-401. DWITHIN corrected to handle the unit conv…#403
GEOWAVE-398 & GEOWAVE-401. DWITHIN corrected to handle the unit conv…#403rwgdrummer merged 1 commit intomasterfrom
Conversation
1 similar comment
There was a problem hiding this comment.
consider handling dateline crossing here
|
Addressed one comment and left the other. Thinking better to have a false positive than a negative. |
There was a problem hiding this comment.
I think this really should cover us as much as we can for the dateline. In the last commit, this check was really all I was alluding to.
1 similar comment
ed53a3b to
9714f75
Compare
There was a problem hiding this comment.
This method does not always give proper results. For example, it currently transforms long=116, lat=400 to long=116, lat=90 when the proper result should be long=116, lat=40.
Why do we call adjustCoordinateDimensionToRange() for the X coordinate but clipRange() for the Y and Z coordinates? Shouldn't all three coordinates rely on adjustCoordinateDimensionToRange()? It looks like the issues are stemming from clipRange()...
There was a problem hiding this comment.
adjustCoordinateDimensionToRange() is just the wrong math to do with y and z - they don't have the same reflection property at the extrema.
90 + 1 degrees latitude is arguably 89 degrees instead of clamping at 90 but its definitely not -89 (you wouldn't want to shift from north to south pole)
…e unit conversion properly from distance (meters, km, etc.) to decimal degrees (EPSG:4326 long/lat). There is still a degree of error difficult to compensate for when dealing polygons (e.g a country). Future work will adopt a more accurate approach consistent with other LocationTech projects Add 'some' support date line crossing for the DWITHIN function Clip hemisphere crossing. A separate issue will be made for dealing the poles.
GEOWAVE-398 & GEOWAVE-401. DWITHIN corrected to handle the unit conv…
…ersion properly from distance (meters, km, etc.) to decimal degrees (EPSG:4326 long/lat). There is still a degree of error difficult to compensate for when dealing polygons (e.g a country). Future work will adopt a more accurate approach consistent with other LocationTech projects