Skip to content

Added GeoTools query example#378

Merged
rfecher merged 2 commits intomasterfrom
GEOWAVE-116_1
May 11, 2015
Merged

Added GeoTools query example#378
rfecher merged 2 commits intomasterfrom
GEOWAVE-116_1

Conversation

@dcy2003
Copy link
Copy Markdown
Contributor

@dcy2003 dcy2003 commented May 7, 2015

GeoTools query example for #116

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.32%) to 62.87% when pulling 523096f on GEOWAVE-116_1 into cf04123 on master.

@chrisbennight
Copy link
Copy Markdown
Contributor

Didn't dig into the code, but from looking at the errors it looks like you might need to add a maven munge directive here - seems there might by a method being called that's not valid for accumulo 1.5

@rfecher
Copy link
Copy Markdown
Contributor

rfecher commented May 8, 2015

I didn't see it that way, at least in the last failure what I saw was it failing on a random zookeeper transaction related test unrelated to this example code. I think there's at least two random failures in our tests, I ticketed one #361 and I probably should have added an issue for this before restarting. We'll probably see it again.

@chrisbennight
Copy link
Copy Markdown
Contributor

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.3.2:compile (default-compile) on project geowave-example: Compilation failure
[ERROR] /home/travis/build/ngageoint/geowave/examples/src/main/java/mil/nga/giat/geowave/examples/query/GeotoolsQueryExample.java:[133,14] error: cannot find symbol

line 133 is
https://github.com/ngageoint/geowave/blob/GEOWAVE-116_1/examples/src/main/java/mil/nga/giat/geowave/examples/query/GeotoolsQueryExample.java#L133

or

accumulo.getConnector(  ACCUMULO_USER, ACCUMULO_PASSWORD)

where accumulo is org.apache.accumulo.minicluster.MiniAccumuloCluster

the getConnector method is marked as "since 1.6.0"
https://github.com/apache/accumulo/blob/master/minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloCluster.java#L110

.

I think I win! :)

@jwomeara
Copy link
Copy Markdown
Contributor

jwomeara commented May 8, 2015

We test against 1.5.2 in travis. :)

https://github.com/ngageoint/geowave/blob/master/.travis.yml#L7

Coincedentally, your test is only failing in 1.5.2 on travis.

https://travis-ci.org/ngageoint/geowave/builds/61651413

Munge it up, brother!

EDIT: Dogpile!!!

On Fri, May 8, 2015 at 4:18 PM, Chris Bennight notifications@github.com
wrote:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.3.2:compile (default-compile) on project geowave-example: Compilation failure
[ERROR] /home/travis/build/ngageoint/geowave/examples/src/main/java/mil/nga/giat/geowave/examples/query/GeotoolsQueryExample.java:[133,14] error: cannot find symbol

line 133 is

https://github.com/ngageoint/geowave/blob/GEOWAVE-116_1/examples/src/main/java/mil/nga/giat/geowave/examples/query/GeotoolsQueryExample.java#L133

or

accumulo.getConnector( ACCUMULO_USER, ACCUMULO_PASSWORD)

where accumulo is org.apache.accumulo.minicluster.MiniAccumuloCluster

the getConnector method is marked as "since 1.6.0"

https://github.com/apache/accumulo/blob/master/minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloCluster.java#L110

.

I think I win! :)


Reply to this email directly or view it on GitHub
#378 (comment).

@chrisbennight
Copy link
Copy Markdown
Contributor

To be fair, could possibly skip munge and just go with a 1.5 compatible method if it isn't deprecated.

Hopefully when 1.7 get's out we can cut some of the 1.5 support.

@rfecher
Copy link
Copy Markdown
Contributor

rfecher commented May 9, 2015

@chrisbennight you win this time ;)

I don't know what I was looking at with the transaction stuff - I'll just stick to the claim that the one test I had restarted happened to have the random issue before it got to compiling the examples.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.28%) to 62.91% when pulling 6fd8f8e on GEOWAVE-116_1 into cf04123 on master.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.19%) to 63.03% when pulling c253a5f on GEOWAVE-116_1 into b127ff1 on master.

@dcy2003
Copy link
Copy Markdown
Contributor Author

dcy2003 commented May 10, 2015

Sorry for the oversight - should be fixed now. I took @chrisbennight recommended approach and simply avoided the use of a 1.6-only method.

rfecher added a commit that referenced this pull request May 11, 2015
@rfecher rfecher merged commit 38b3d85 into master May 11, 2015
@rfecher rfecher deleted the GEOWAVE-116_1 branch May 11, 2015 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants