Merged
Conversation
Contributor
|
I looked through the files, and it looks like a good example. If we choose to follow-on with this to add more re-usable components, one thought would be to try to minimize the constants defined near the top of SimpleFeatureToAccumuloKeyValueMapper to provide a re-usable mapper that can be given the index and adapter through the job context, and the key generator could be more hidden so that the implementor could call something like writeNativeObject and the key generator would then take the native object and write the collection of key value pairs to the context...anyways, just a thought, not sure if its worth putting more into this yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation for #157 ...
The crux of the solution is within
AccumuloKeyValuePairGeneratorwhich produces Accumulo [Key,Value] pairs (Geowave-formatted) given an adapter and an index, similar to the way we currently produce Mutations.To fully demonstrate the "flow" of this solution, I created an example MapReduce job that:
Feedback welcome!