Conversation
Contributor
Author
There was a problem hiding this comment.
2 threads per core on builds; seems to give a 2-10 minute speedup on travis.
Note that the install/javadoc version throws an exception using this.
1 similar comment
Contributor
Author
There was a problem hiding this comment.
I think this logic is correct; intent here (and in the other iterators changed in the same pattern) was to actually throw NoSuchElementException() when .next() was called on the end element. (It looks like we would just return null in that case instead - but normally never got there because it was guarded with hasNext())
0679047 to
0e6504e
Compare
rfecher
added a commit
that referenced
this pull request
Mar 31, 2015
Findbugs; add to verify phase, address current issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#228
Also added findbugs to the build now; had to exempt a few visitors (see the omitVisitors property) - all of them basically caused by
it's that mutable state / security warning we talked about. There's ~90 of those across the whole project that are not tracked. Not necessarily issues, but probably need to take the time to verify before we annotate them directly.
But for any of the other errors findbugs will now fail the build. The error will be printed in the mvn output, but the easiest way is either to get a findbugs plugin in your ide, or if you type
a window detailing and explaining the issues will pop up for each module build
also hits an admittedly unrelated javadoc issue - the -Xdoclint:none command needed to make java8 not blow up causes java7 to blow up. This was preventing the install phase from finishing, which caused the verify phase to pull old libraries from the cache, which led to random results - so resolved it here (with a profile that injects the argument and only activates for java8+)