Skip to content

GEOWAVE-189#194

Merged
rfecher merged 1 commit intomasterfrom
GEOWAVE-189
Jan 25, 2015
Merged

GEOWAVE-189#194
rfecher merged 1 commit intomasterfrom
GEOWAVE-189

Conversation

@rwgdrummer
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks like a minor oversight. I think it is supposed to be this.getEndRange().getEndTime(). are these bounds(), lowerBounds(), and upperBounds() methods used? I didn't see where at least and was just trying to understand the intended purpose particularly with lower and upper bounds methods. I was thinking set theory operations like union and intersection could make sense on time ranges but this upper and lower bounds for time ranges that don't overlap would produce invalid time ranges, and it just wasn't clear to me what its supposed to be doing particularly in that non-overlapping case.

@rwgdrummer
Copy link
Copy Markdown
Contributor Author

Comments addressed as part of review.

rfecher added a commit that referenced this pull request Jan 25, 2015
@rfecher rfecher merged commit e74b937 into master Jan 25, 2015
@rfecher rfecher deleted the GEOWAVE-189 branch January 25, 2015 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants