Merged
Conversation
rfecher
approved these changes
Mar 27, 2017
|
|
||
| if (admin.getConfiguration().getInt( | ||
| "hfile.format.version", | ||
| 0) != 3) { |
Contributor
There was a problem hiding this comment.
">= 3" seems like it would future proof us from log spam
| private final Connection conn; | ||
| private final String tableNamespace; | ||
| private final boolean schemaUpdateEnabled; | ||
| private final HashMap<String, List<String>> coprocessorCache = new HashMap<String, List<String>>(); |
Contributor
There was a problem hiding this comment.
perhaps outside of the scope of this issue, but food for thought it may be nice to have something like the Cassandra implementation of KeyspaceStatePool that basically caches stateful data so that it can be used across instances of the Operations. In other words, if the lifecycle of these operations objects is short-lived the cache could become less useful, but definitely not something that needs immediate attention.
| "hfile.format.version"); | ||
| assertTrue( | ||
| "HFile version is incorrect", | ||
| hfileVersionStr.equals("3")); |
Contributor
There was a problem hiding this comment.
this is less of a problem because we control the test environment, but still, maybe it'd be more flexible to make this >= 3?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.