Skip to content

add retry for GH release creation #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alexrashed merged 1 commit into from
Sep 22, 2025
Merged

add retry for GH release creation #79

alexrashed merged 1 commit into from
Sep 22, 2025

Conversation

@alexrashed
Copy link
Member

@alexrashed alexrashed commented Sep 22, 2025 •
edited
Loading

Motivation

Last week we added a CI workflow to automatically sync and release this fork for us (see #78).
Unfortunately, one step is still not stable: The actual creation of the release on GitHub. While this is optional, it would be nice to have the release properly being shown in the UI.
The step fails with the following error:

To https://github.com/localstack/moto
 + 662f5b948...8e3016550 localstack -> localstack (forced update)
To https://github.com/localstack/moto
 * [new tag]             5.1.13.post7 -> 5.1.13.post7
tag 5.1.13.post7 exists locally but has not been pushed to getmoto/moto, please push it before continuing or specify the `--target` flag to create a new tag
Error: Process completed with exit code 1.

The logs clearly show that the tag is pushed, but is not recognized by GitHub right afterwards.
This PR tries to address this issue by wrapping the release creation into a "retry" action.

Changes

  • Wrap the creation of the release on GitHub into a "retry" action

@alexrashed alexrashed marked this pull request as ready for review September 22, 2025 11:27
viren-nadkarni
viren-nadkarni approved these changes Sep 22, 2025
View reviewed changes
Copy link
Member

@viren-nadkarni viren-nadkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up on this, looks good to me!

.github/workflows/ci.yml
uses: nick-fields/retry@v3
with:
max_attempts: 5
retry_wait_seconds: 120
Copy link
Member

@viren-nadkarni viren-nadkarni Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could use a shorter wait and more retries to avoid keeping the CI worker blocked

@alexrashed alexrashed merged commit 7498008 into localstack Sep 22, 2025
19 of 27 checks passed
localstack-bot pushed a commit that referenced this pull request Sep 29, 2025
@alexrashed @localstack-bot
add retry for GH release creation (#79)
294bfa8
@alexrashed alexrashed deleted the fix-release-creation branch September 29, 2025 07:25
alexrashed added a commit that referenced this pull request Sep 29, 2025
@alexrashed
add CI workflow to sync, build, publish, release moto-ext (#78,#79)
ecfd20f
@alexrashed
Copy link
Member Author

alexrashed commented Sep 29, 2025

FYI: There was one more fix necessary (adding timeout_minutes). I pushed a fix for this on the localstack branch and also combined the changes of this PR with the changes of #78, just to keep the distance / amount of commits on top of moto as low as possible.

localstack-bot pushed a commit that referenced this pull request Oct 6, 2025
@alexrashed @localstack-bot
add CI workflow to sync, build, publish, release moto-ext (#78,#79)
82d41e3
alexrashed added a commit that referenced this pull request Oct 6, 2025
@alexrashed
add CI workflow to sync, build, publish, release moto-ext (#78,#79)
cd2fbeb
alexrashed added a commit that referenced this pull request Oct 6, 2025
@alexrashed
add CI workflow to sync, build, publish, release moto-ext (#78,#79)
d162bde
@alexrashed
Copy link
Member Author

alexrashed commented Oct 6, 2025 •
edited
Loading

FYI: One more fix was necessary (adding the GH_TOKEN env var to the step creating the release). I again combined this with the changes of #78 to have minimum distance to upstream moto.

localstack-bot pushed a commit that referenced this pull request Oct 13, 2025
@alexrashed @localstack-bot
add CI workflow to sync, build, publish, release moto-ext (#78,#79)
44fb05b
alexrashed added a commit that referenced this pull request Oct 20, 2025
@alexrashed
add CI workflow to sync, build, publish, release moto-ext (#78,#79)
397fe9c
alexrashed added a commit that referenced this pull request Oct 20, 2025
@alexrashed
add CI workflow to sync, build, publish, release moto-ext (#78,#79)
064501c
alexrashed added a commit that referenced this pull request Oct 20, 2025
@alexrashed
add CI workflow to sync, build, publish, release moto-ext (#78,#79)
eedacd8
alexrashed added a commit that referenced this pull request Oct 20, 2025
@alexrashed
add CI workflow to sync, build, publish, release moto-ext (#78,#79)
d6f7496
localstack-bot pushed a commit that referenced this pull request Oct 29, 2025
@alexrashed @localstack-bot
add CI workflow to sync, build, publish, release moto-ext (#78,#79)
9be0f0e
alexrashed added a commit that referenced this pull request Oct 29, 2025
@alexrashed
add CI workflow to sync, build, publish, release moto-ext (#78,#79)
123e149
alexrashed added a commit that referenced this pull request Nov 4, 2025
@alexrashed
add CI workflow to sync, build, publish, release moto-ext (#78,#79)
83de255
localstack-bot pushed a commit that referenced this pull request Nov 10, 2025
@alexrashed @localstack-bot
add CI workflow to sync, build, publish, release moto-ext (#78,#79)
4847e97
localstack-bot pushed a commit that referenced this pull request Nov 17, 2025
@alexrashed @localstack-bot
add CI workflow to sync, build, publish, release moto-ext (#78,#79)
f8fd1dc
localstack-bot pushed a commit that referenced this pull request Nov 24, 2025
@alexrashed @localstack-bot
add CI workflow to sync, build, publish, release moto-ext (#78,#79)
7aed699
localstack-bot pushed a commit that referenced this pull request Dec 1, 2025
@alexrashed @localstack-bot
add CI workflow to sync, build, publish, release moto-ext (#78,#79)
3306322
localstack-bot pushed a commit that referenced this pull request Dec 8, 2025
@alexrashed @localstack-bot
add CI workflow to sync, build, publish, release moto-ext (#78,#79)
e45c81c
localstack-bot pushed a commit that referenced this pull request Dec 15, 2025
@alexrashed @localstack-bot
add CI workflow to sync, build, publish, release moto-ext (#78,#79)
bf5e39e
silv-io pushed a commit that referenced this pull request Dec 15, 2025
@alexrashed @silv-io
add CI workflow to sync, build, publish, release moto-ext (#78,#79)
770309a
localstack-bot pushed a commit that referenced this pull request Dec 22, 2025
@alexrashed @localstack-bot
add CI workflow to sync, build, publish, release moto-ext (#78,#79)
02f523d
localstack-bot pushed a commit that referenced this pull request Dec 29, 2025
@alexrashed @localstack-bot
add CI workflow to sync, build, publish, release moto-ext (#78,#79)
e2ecfd9
localstack-bot pushed a commit that referenced this pull request Jan 5, 2026
@alexrashed @localstack-bot
add CI workflow to sync, build, publish, release moto-ext (#78,#79)
7b48ab2
localstack-bot pushed a commit that referenced this pull request Jan 7, 2026
@alexrashed @localstack-bot
add CI workflow to sync, build, publish, release moto-ext (#78,#79)
9ad3a7b
localstack-bot pushed a commit that referenced this pull request Jan 12, 2026
@alexrashed @localstack-bot
add CI workflow to sync, build, publish, release moto-ext (#78,#79)
de1bea9
localstack-bot pushed a commit that referenced this pull request Jan 13, 2026
@alexrashed @localstack-bot
add CI workflow to sync, build, publish, release moto-ext (#78,#79)
ac09d7e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@viren-nadkarni viren-nadkarni viren-nadkarni approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexrashed @viren-nadkarni