Skip to content

RDS: Patch the list of valid DB engines #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
viren-nadkarni merged 1 commit into from
Nov 21, 2023
Merged

RDS: Patch the list of valid DB engines #72

viren-nadkarni merged 1 commit into from
Nov 21, 2023

Conversation

@viren-nadkarni
Copy link
Member

@viren-nadkarni viren-nadkarni commented Nov 21, 2023

getmoto#7002 introduced additional validations for RDS engine types.

This PR updates the list of valid engines as in LocalStack.

@viren-nadkarni viren-nadkarni self-assigned this Nov 21, 2023
@viren-nadkarni viren-nadkarni mentioned this pull request Nov 21, 2023
Merged
steffyP
steffyP approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@steffyP steffyP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch, @viren-nadkarni! 🙏
LGTM!

@viren-nadkarni viren-nadkarni merged commit 0aa7fc1 into localstack Nov 21, 2023
@viren-nadkarni viren-nadkarni deleted the rds-valid-engines branch November 21, 2023 09:37
viren-nadkarni added a commit that referenced this pull request Dec 12, 2023
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
82f3902
viren-nadkarni added a commit that referenced this pull request Jan 8, 2024
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
a12bd77
alexrashed pushed a commit that referenced this pull request Jan 24, 2024
@viren-nadkarni @alexrashed
RDS: Patch the list of valid DB engines (#72)
ab20b2c
viren-nadkarni added a commit that referenced this pull request Jan 29, 2024
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
4c82392
viren-nadkarni added a commit that referenced this pull request Jan 29, 2024
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
b1aef6a
viren-nadkarni added a commit that referenced this pull request Feb 20, 2024
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
45f1e0e
viren-nadkarni added a commit that referenced this pull request Mar 4, 2024
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
036a510
viren-nadkarni added a commit that referenced this pull request Mar 4, 2024
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
f995cdc
viren-nadkarni added a commit that referenced this pull request Mar 4, 2024
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
66b8a0f
viren-nadkarni added a commit that referenced this pull request Mar 5, 2024
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
5c60284
viren-nadkarni added a commit that referenced this pull request Mar 19, 2024
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
b3e8788
viren-nadkarni added a commit that referenced this pull request Apr 2, 2024
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
21389bc
viren-nadkarni added a commit that referenced this pull request Apr 11, 2024
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
93d671b
viren-nadkarni added a commit that referenced this pull request May 3, 2024
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
f15024c
viren-nadkarni added a commit that referenced this pull request May 10, 2024
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
99479df
viren-nadkarni added a commit that referenced this pull request May 17, 2024
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
5ff16f7
viren-nadkarni added a commit that referenced this pull request May 22, 2024
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
2bd31be
viren-nadkarni added a commit that referenced this pull request May 27, 2024
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
fae59f9
viren-nadkarni added a commit that referenced this pull request Jun 7, 2024
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
ef1cdaa
viren-nadkarni added a commit that referenced this pull request Jun 20, 2024
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
04661fa
viren-nadkarni added a commit that referenced this pull request Jul 3, 2024
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
022c04e
viren-nadkarni added a commit that referenced this pull request Jul 18, 2024
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
bd4ca19
viren-nadkarni added a commit that referenced this pull request Aug 9, 2024
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
176a3dd
viren-nadkarni added a commit that referenced this pull request Oct 18, 2024
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
0b518c3
viren-nadkarni added a commit that referenced this pull request Oct 28, 2024
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
3efa10d
viren-nadkarni added a commit that referenced this pull request Nov 12, 2024
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
2b6db03
viren-nadkarni added a commit that referenced this pull request Dec 9, 2024
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
4d282fa
viren-nadkarni added a commit that referenced this pull request Dec 30, 2024
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
ca8aa5c
viren-nadkarni added a commit that referenced this pull request Jan 6, 2025
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
09d181a
viren-nadkarni added a commit that referenced this pull request Jan 14, 2025
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
9015960
k-a-il pushed a commit that referenced this pull request Jan 30, 2025
@viren-nadkarni @k-a-il
RDS: Patch the list of valid DB engines (#72)
3857f4b
viren-nadkarni added a commit that referenced this pull request Feb 10, 2025
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
670c942
viren-nadkarni added a commit that referenced this pull request Feb 14, 2025
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
71f9b91
viren-nadkarni added a commit that referenced this pull request Feb 20, 2025
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
d9dd456
viren-nadkarni added a commit that referenced this pull request Feb 21, 2025
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
bc3c79e
viren-nadkarni added a commit that referenced this pull request Mar 17, 2025
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
5236e9f
viren-nadkarni added a commit that referenced this pull request Apr 8, 2025
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
d6d641a
viren-nadkarni added a commit that referenced this pull request Apr 29, 2025
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
695743e
viren-nadkarni added a commit that referenced this pull request May 21, 2025
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
668b320
viren-nadkarni added a commit that referenced this pull request May 29, 2025
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
b322422
viren-nadkarni added a commit that referenced this pull request Jun 16, 2025
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
e05e822
viren-nadkarni added a commit that referenced this pull request Jun 24, 2025
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
a30bdbf
viren-nadkarni added a commit that referenced this pull request Aug 6, 2025
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
2bd1f59
viren-nadkarni added a commit that referenced this pull request Aug 14, 2025
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
87a71d4
viren-nadkarni added a commit that referenced this pull request Aug 14, 2025
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
fd5b8dd
viren-nadkarni added a commit that referenced this pull request Aug 19, 2025
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
168ef5e
viren-nadkarni added a commit that referenced this pull request Aug 20, 2025
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
2489438
viren-nadkarni added a commit that referenced this pull request Aug 25, 2025
@viren-nadkarni
RDS: Patch the list of valid DB engines (#72)
3842ca6
localstack-bot pushed a commit that referenced this pull request Sep 15, 2025
@viren-nadkarni @localstack-bot
RDS: Patch the list of valid DB engines (#72)
3bc7702
localstack-bot pushed a commit that referenced this pull request Sep 22, 2025
@viren-nadkarni @localstack-bot
RDS: Patch the list of valid DB engines (#72)
8213fb9
localstack-bot pushed a commit that referenced this pull request Sep 29, 2025
@viren-nadkarni @localstack-bot
RDS: Patch the list of valid DB engines (#72)
b4a9bac
localstack-bot pushed a commit that referenced this pull request Oct 6, 2025
@viren-nadkarni @localstack-bot
RDS: Patch the list of valid DB engines (#72)
3a3d447
localstack-bot pushed a commit that referenced this pull request Oct 13, 2025
@viren-nadkarni @localstack-bot
RDS: Patch the list of valid DB engines (#72)
8c73566
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@steffyP steffyP steffyP approved these changes

Assignees

@viren-nadkarni viren-nadkarni

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@viren-nadkarni @steffyP