Add basic cloudwatch metrics for new lambda provider#8006
Merged
dominikschubert merged 1 commit intomasterfrom Mar 29, 2023
Merged
Add basic cloudwatch metrics for new lambda provider#8006dominikschubert merged 1 commit intomasterfrom
dominikschubert merged 1 commit intomasterfrom
Conversation
steffyP
approved these changes
Mar 29, 2023
Member
steffyP
left a comment
There was a problem hiding this comment.
Thanks for jumping on this so quickly! 🙏
LGTM :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SImply restores parity with the old provider in regards to the CloudWatch metrics we record in the service.
Records two metrics (same as the old provider):
Invocations... a simple numeric counter. Records 1 for each invocation result (both success & result)Errors... simple numeric counter. Records 1 for each invocation error. This also applies to failed retriesThe only other change to the old provider here is that we now connect to the correct region when sending the records.
Would be a cool project to extend this and add proper parity with AWS for all the service level metrics.