Conversation
There was a problem hiding this comment.
Just a few minor nits, otherwise LGTM.
Looking forward to extending these kind of inline suggestions in the logs. We might have to think about adding a separate logger for those though, so we're able to disable them if some might find them too intrusive.
One thing that I'm also a bit curious about is how stable the links to the docs pages will be since we don't really have a strategy in place for redirecting older pages, etc. so this might be outdated quite quickly.
| # host under which the LocalStack services are available from Lambda Docker containers | ||
| # DEPRECATED: only applies to old lambda provider | ||
| # Endpoint host under which LocalStack APIs are accessible from Lambda Docker containers. | ||
| HOSTNAME_FROM_LAMBDA = os.environ.get("HOSTNAME_FROM_LAMBDA", "").strip() |
There was a problem hiding this comment.
not sure if we're not actually gonna have to keep that for some edge cases 🤔
There was a problem hiding this comment.
agreed. We might want adopt the new host terminology instead of hostname in that case 🤔
Valid point because that reference becomes implicit knowledge. I introduced aliases when doing the Lambda doc re-work for backwards compatibility. I typically try to support page renames but anchors within a page might break after some refactoring. |
In addition to deprecation warning
b19acfe to
93a1d8f
Compare
Add and improve lambda deprecation warnings:
deprecations.pyon_after_initwhen the lambda provider is loaded through delegation to the runtime executor in.validate_environment()DockerNotAvailableis raisedPendingorFailedDockerNotAvailable