Skip to content

Add GATEWAY_LISTEN to analytics events#7977

Merged
simonrw merged 1 commit intomasterfrom
add-gateway-listen-to-analytics
Mar 27, 2023
Merged

Add GATEWAY_LISTEN to analytics events#7977
simonrw merged 1 commit intomasterfrom
add-gateway-listen-to-analytics

Conversation

@simonrw
Copy link
Contributor

@simonrw simonrw commented Mar 27, 2023

We added GATEWAY_LISTEN to our list of configuration variables, so we should track whether this is being used by anyone or not.

It has been added to the "track existence but not value" section because it may leak user internals (though not likely... 😂).

@simonrw simonrw self-assigned this Mar 27, 2023
@simonrw simonrw requested a review from ackdav March 27, 2023 14:19
@coveralls
Copy link

Coverage Status

Coverage: 81.758% (+0.004%) from 81.754% when pulling 4c98f8f on add-gateway-listen-to-analytics into 1d81bc9 on master.

Copy link
Member

@ackdav ackdav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 lgtm :)

@simonrw simonrw merged commit 558649b into master Mar 27, 2023
@alexrashed alexrashed deleted the add-gateway-listen-to-analytics branch April 7, 2023 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants