Skip to content

Adds support for arrays in event bridge rule pattern#7947

Merged
dominikschubert merged 2 commits intolocalstack:masterfrom
bruno-imx:master
Mar 27, 2023
Merged

Adds support for arrays in event bridge rule pattern#7947
dominikschubert merged 2 commits intolocalstack:masterfrom
bruno-imx:master

Conversation

@bruno-imx
Copy link
Contributor

Suggestion implementation for issue (Add support for arrays in EventBridge event patterns)

As per AWS documentation, an event pattern that includes the following field

"type": ["A", "B"]

The preceding event pattern matches an event that includes the following field because the first item in the event pattern array matches the second item in the event array.

"type": [ "C",  "A" ]

Copy link
Contributor

@localstack-bot localstack-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to LocalStack! Thanks for raising your first Pull Request and landing in your contributions. Our team will reach out with any reviews or feedbacks that we have shortly. We recommend joining our Slack Community and share your PR on the #community channel to share your contributions with us. Please make sure you are following our contributing guidelines and our Code of Conduct.

@localstack-bot
Copy link
Contributor

localstack-bot commented Mar 24, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@bruno-imx
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@bruno-imx
Copy link
Contributor Author

recheck

Copy link
Member

@dominikschubert dominikschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! 🚀

I'll try to improve the test suite in test_events.py soon to be more compatible with running the suite against AWS ( a requirement for the aws_validated marker).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants